commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niall Pemberton (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (IO-74) Regular expression file name filter implementation
Date Sat, 13 Oct 2007 01:57:50 GMT

    [ https://issues.apache.org/jira/browse/IO-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534425
] 

niallp edited comment on IO-74 at 10/12/07 6:55 PM:
-------------------------------------------------------------

Thanks for the patch Oliver - I have added this, but also done some refactoring. I removed
the facility to specify arrays/lists of regular expression Strings for a number of reasons

- firstly seemed like a good idea to add constructors that specifying either Pattern flags
or case sensitivity (using IOCase), but adding all flavours for flags/case and array/List
seemed cumbersome.
- also the array/list facility only catered for OR conditions which is limiting since users
may want AND - Commons IO already contains AndFileFilter / OrFileFilter implementations which
can be used with RegexFileFilter to achieve both

http://svn.apache.org/viewvc/commons/proper/io/trunk/src/java/org/apache/commons/io/filefilter/RegexFileFilter.java?view=log

      was (Author: niallp):
    Thanks for the patch Oliver - I have added this, but also done some refactoring. I removed
the facility to specify arrays/lists of regular expression Strings for a number of reasons

- firstly seemed like a good idea to add constructors that specifying either Pattern flags
or case sensitivity (using IOCase), but adding all flavours for flags/case and array/List
seemed cumbersome.
- also the array/list facility only catered for OR conditions which is limiting since users
may want AND - Commons IO already contains AndFileFilter / OrFileFilter implementations which
can be used with RegexFileFilter to achieve both

http://svn.apache.org/viewvc/commons/proper/io/trunk/src/java/org/apache/commons/io/filefilter/RegexFilter.java?view=log
  
> Regular expression file name filter implementation
> --------------------------------------------------
>
>                 Key: IO-74
>                 URL: https://issues.apache.org/jira/browse/IO-74
>             Project: Commons IO
>          Issue Type: Improvement
>          Components: Filters
>         Environment: Operating System: other
> Platform: Other
>            Reporter: Oliver Siegmar
>            Assignee: Niall Pemberton
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: commons-io_regexfilter.patch
>
>
> I've written a RegexFilter for commons-io. I'd like to share it with other's.
> Hope there'll be a JDK 1.4+ branch soon, so this can be applied.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message