commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephen Kestle <>
Subject Re: [jira] Created: (COLLECTIONS-273) Generify functors
Date Tue, 30 Oct 2007 20:21:45 GMT
Wow - Brian - getting a move on!  Patches are always welcome.  What I am 
doing is basically making a project for every patch I get, and then 
merging them in as I make changes (to see if there's anything left of 

Hmm.  Looks like I really need to get CollectionUtils in sooner rather 
than later.  Generics is troublesome enough that we need to be really 
vigilant about edge test cases. 

e.g. in the functors.patch,

TransformedCollection.decorate(new ArrayList<String>(), NOOP_TRANSFORMER)
returns a Collection<String> - it should also be able to return a Collection<Object>.
 Trust me, it's useful.

And all these should be tested.  We really need to ensure that our tests 
show something as broken, and then fix them.  The strange thing about 
"testing" generics is that it's at compile time, so merely having the 
code in the test case is sufficient.

JavaDoc is also really important for patches.  I'm using generic method 
declarations as markers of completeness, so I'm not committing unless 
documentation is up to standard.  This also slows committing down.

Unfortunately, I don't know when ASAP is...

Brian Egge (JIRA) wrote:
> Generify functors
> -----------------
>                  Key: COLLECTIONS-273
>                  URL:
>              Project: Commons Collections
>           Issue Type: Improvement
>     Affects Versions: Generics
>             Reporter: Brian Egge
>             Priority: Minor
>          Attachments: functors.patch
> I generified most of the functors.  I didn't touch the transformer classes, as I need
to think about those a bit more.

View raw message