commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Benson (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (LANG-362) Add ExtendedMessageFormat to org.apache.commons.lang.text
Date Mon, 29 Oct 2007 16:06:51 GMT

    [ https://issues.apache.org/jira/browse/LANG-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538109
] 

mbenson edited comment on LANG-362 at 10/29/07 9:06 AM:
------------------------------------------------------------

Remove MetaFormat interface; make DefaultMetaFormatFactory package-private, delegate new static
methods on ExtendedMessageFormat to it; add metaFormat settor to ExtendedMF to complement
applyPattern() which can be called "later"; renamed AbstractMetaFormat to MetaFormatSupport;
renamed AbstractDateMetaFormat to DateMetaFormatSupport (yes, a nod to Spring); made sure
all inherited javadoc has something to inherit (I think).

The packaging issue is outstanding, but since I removed an interface and made one class visible
only inside its package, the impact of leaving this stuff in oacl.text is less severe; ultimately
I don't really care whether they go in text or text.format however.

EDIT:  other issues addressed:  s/reverse(Map)/invert(Map)/; added example documentation for
MultiFormat and NamedKeyMetaFormat Builders.

      was (Author: mbenson):
    Remove MetaFormat interface; make DefaultMetaFormatFactory package-private, delegate new
static methods on ExtendedMessageFormat to it; add metaFormat settor to ExtendedMF to complement
applyPattern() which can be called "later"; renamed AbstractMetaFormat to MetaFormatSupport;
renamed AbstractDateMetaFormat to DateMetaFormatSupport (yes, a nod to Spring); made sure
all inherited javadoc has something to inherit (I think).

The packaging issue is outstanding, but since I removed an interface and made one class visible
only inside its package, the impact of leaving this stuff in oacl.text is less severe; ultimately
I don't really care whether they go in text or text.format however.
  
> Add ExtendedMessageFormat to org.apache.commons.lang.text
> ---------------------------------------------------------
>
>                 Key: LANG-362
>                 URL: https://issues.apache.org/jira/browse/LANG-362
>             Project: Commons Lang
>          Issue Type: New Feature
>            Reporter: Matt Benson
>            Assignee: Matt Benson
>            Priority: Minor
>             Fix For: 2.4
>
>         Attachments: extendedMessageFormat.patch.txt, extendedMessageFormat.patch.txt
>
>
> Discussed on dev@ ( http://mail-archives.apache.org/mod_mbox/commons-dev/200710.mbox/%3c590921.30381.qm@web55103.mail.re4.yahoo.com%3e
); adding here for tracking purposes and in case anyone has any serious objections to my implementation.
 Patch forthcoming...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message