From issues-return-95-apmail-commons-issues-archive=commons.apache.org@commons.apache.org Wed Aug 08 15:55:38 2007 Return-Path: Delivered-To: apmail-commons-issues-archive@locus.apache.org Received: (qmail 35977 invoked from network); 8 Aug 2007 15:55:25 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 8 Aug 2007 15:55:25 -0000 Received: (qmail 79674 invoked by uid 500); 8 Aug 2007 15:55:22 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 79468 invoked by uid 500); 8 Aug 2007 15:55:21 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 79459 invoked by uid 99); 8 Aug 2007 15:55:21 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Aug 2007 08:55:21 -0700 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Aug 2007 15:55:19 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 86A99714168 for ; Wed, 8 Aug 2007 08:54:59 -0700 (PDT) Message-ID: <22031433.1186588499548.JavaMail.jira@brutus> Date: Wed, 8 Aug 2007 08:54:59 -0700 (PDT) From: "Henri Yandell (JIRA)" To: issues@commons.apache.org Subject: [jira] Reopened: (LANG-329) Pointless synchronized in ThreadLocal.initialValue should be removed MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LANG-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Yandell reopened LANG-329: -------------------------------- > Pointless synchronized in ThreadLocal.initialValue should be removed > -------------------------------------------------------------------- > > Key: LANG-329 > URL: https://issues.apache.org/jira/browse/LANG-329 > Project: Commons Lang > Issue Type: Improvement > Affects Versions: 2.3 > Environment: Any > Reporter: Hanson Char > Priority: Trivial > Fix For: 2.3.1 > > > --- jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ToStringStyle.java 2007/01/27 07:13:59 500497 > +++ jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ToStringStyle.java 2007/04/20 05:06:03 530645 > @@ -103,7 +103,7 @@ > *

> */ > private static ThreadLocal registry = new ThreadLocal() { > - protected synchronized Object initialValue() { > + protected Object initialValue() { > // The HashSet implementation is not synchronized, > // which is just what we need here. > return new HashSet(); > --- jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/HashCodeBuilder.java 2006/09/19 21:58:11 447989 > +++ jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/HashCodeBuilder.java 2007/04/20 05:11:46 530648 > @@ -103,7 +103,7 @@ > * @since 2.3 > */ > private static ThreadLocal registry = new ThreadLocal() { > - protected synchronized Object initialValue() { > + protected Object initialValue() { > // The HashSet implementation is not synchronized, > // which is just what we need here. > return new HashSet(); -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.