commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Yandell (JIRA)" <j...@apache.org>
Subject [jira] Updated: (EL-11) [el] VariableResolverImpl is ignorant of the implicit variables 'request' and 'response'
Date Mon, 20 Aug 2007 13:53:30 GMT

     [ https://issues.apache.org/jira/browse/EL-11?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Henri Yandell updated EL-11:
----------------------------

    Attachment: EL-11.patch

Supporting request and response seems very easy - patch attached.

Looking at the spec and looking at the code, there's no similarity between the two list of
variables, so even without the thoughts of backwards compat, I'm dubious on removing pageContext.

> [el] VariableResolverImpl is ignorant of the implicit variables 'request' and 'response'
> ----------------------------------------------------------------------------------------
>
>                 Key: EL-11
>                 URL: https://issues.apache.org/jira/browse/EL-11
>             Project: Commons EL
>          Issue Type: Bug
>    Affects Versions: Nightly Builds
>         Environment: Operating System: other
> Platform: Other
>            Reporter: David Bullock
>             Fix For: 1.1
>
>         Attachments: EL-11.patch
>
>
> I refer you to JSP.8.8 of the JSP 2.0 FR spec (and also of the JSP 2.1 draft),
> where INSTEAD OF the implicit 'pageContext' object, there are meant to be
> 'request' and 'response' implicit objects.
> This isn't working for me with tag files produced by some version of Jasper/EL
> embedded in Sun Java System Application Server 8 (specifically, when I invoke a
> function like '${f:myFunction(request)}' from a tag file, a null pointer is
> passed to the function).  From a fairly quick read of the current source, it
> would appear that the call-stack initiated by
> org.apache.jasper.runtime.PageContextImpl.proprietaryEvaluate(...) ultimately
> defers to org.apache.commons.el.VariableResolverImpl to discover implicit
> objects used in an expression.
> And VariableResolverImpl simply doesn't know about 'request' and 'response'. 
> Notice also that -- when invoked in the context of a Tag file -- it  *shouldn't*
> know about 'pageContext' either.
> http://cvs.apache.org/viewcvs.cgi/jakarta-commons/el/src/java/org/apache/commons/el/VariableResolverImpl.java?rev=1.3&view=markup
> As to whether the Jasper crowd are using Commons EL correctly or not, I'm not to
> judge, but it does seem to me that the EL layer should get the heads up first.
> have fun,
> David.
> My own keywords:  Jasper EL tag file tagfile implicit variable variables request
> response pageContext NullPointerException JSP expression evaluate null

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message