commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Yandell (JIRA)" <j...@apache.org>
Subject [jira] Closed: (LANG-329) Pointless synchronized in ThreadLocal.initialValue should be removed
Date Wed, 08 Aug 2007 15:54:59 GMT

     [ https://issues.apache.org/jira/browse/LANG-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Henri Yandell closed LANG-329.
------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 3.0)
                   2.3.1

> Pointless synchronized in ThreadLocal.initialValue should be removed
> --------------------------------------------------------------------
>
>                 Key: LANG-329
>                 URL: https://issues.apache.org/jira/browse/LANG-329
>             Project: Commons Lang
>          Issue Type: Improvement
>    Affects Versions: 2.3
>         Environment: Any
>            Reporter: Hanson Char
>            Priority: Trivial
>             Fix For: 2.3.1
>
>
> --- jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ToStringStyle.java
2007/01/27 07:13:59	500497
> +++ jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ToStringStyle.java
2007/04/20 05:06:03	530645
> @@ -103,7 +103,7 @@
>       * </p>
>       */
>      private static ThreadLocal registry = new ThreadLocal() {
> -        protected synchronized Object initialValue() {
> +        protected Object initialValue() {
>              // The HashSet implementation is not synchronized,
>              // which is just what we need here.
>              return new HashSet();
> --- jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/HashCodeBuilder.java
2006/09/19 21:58:11	447989
> +++ jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/HashCodeBuilder.java
2007/04/20 05:11:46	530648
> @@ -103,7 +103,7 @@
>       * @since 2.3
>       */
>      private static ThreadLocal registry = new ThreadLocal() {
> -        protected synchronized Object initialValue() {
> +        protected Object initialValue() {
>              // The HashSet implementation is not synchronized,
>              // which is just what we need here.
>              return new HashSet();

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message