commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Romain Manni-Bucau <rmannibu...@gmail.com>
Subject Re: JUnit assertAll and assertThrows question
Date Wed, 14 Oct 2020 19:55:06 GMT
Hi John,

Would be +1 from me if:

1. It does not require to move from junit4 to junit5 (no gain IMHO)
2. Test goes further than a Exception rule or @Test(expected)

If both points are matched it makes sense to me, otherwise it will likely
add more issues from my experience.


Le mer. 14 oct. 2020 à 21:40, John Patrick <nhoj.patrick@gmail.com> a
écrit :

> before i waste time looking at upgrading tests...
>
> any objections if i upgrade tests to use assertAll and assertThrows
> introduced in JUnit jupiter?
>
> I see it as less tech debt removal and I'm happy to spend time doing
> the upgrade which I've done from maybe several projects now. Just
> don't want to get to raising PR and them being rejected, which I feel
> happens with everything I try to help out with related to commons
> projects at the moment...
>
> cheers,
> john
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message