commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1
Date Mon, 11 Feb 2019 18:59:06 GMT
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility
for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r255642430
 
 

 ##########
 File path: src/main/java/org/apache/commons/crypto/jna/OpenSslJnaCryptoRandom.java
 ##########
 @@ -103,10 +103,9 @@ public void nextBytes(byte[] bytes) {
             //to support multithreading https://wiki.openssl.org/index.php/Manual:Threads(3)
needs to be done
             
             if(rdrandEnabled && OpenSslNativeJna.RAND_get_rand_method().equals(OpenSslNativeJna.RAND_SSLeay()))
{
-                close();
 
 Review comment:
   Why do you need to remove this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message