commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject [IO] Provenance of copied code in InfiniteCircularInputStream
Date Mon, 19 Nov 2018 15:59:08 GMT
Hi All and Pascal S.,

Sharon (Eclipse) has pointed out to me that
in org.apache.commons.io.input.InfiniteCircularInputStream.read() [1], we
have:

    @Override
    public int read() {
        position = (position + 1) % repeatedContent.length;
        return repeatedContent[position] & 0xff; // copied from
                                                 //
java.io.ByteArrayInputStream.read()
    }

Where does the code originate? Oracle JRE? OpenJDK? Where? Such a comment
needs to show better provenance since I am pretty sure we are NOT allowed
to copy code from Oracle.

The code was added with the commit

https://github.com/apache/commons-io/commit/699d6f0eca65837501d7ab7a92ae2c614f8e6cbf#diff-5cdd5f292c77ae5feee8f3f101ded473

With this authorship:

[image: @piotrturski] <https://github.com/piotrturski>[image:
@PascalSchumacher] <https://github.com/PascalSchumacher>
piotrturski
<https://github.com/apache/commons-io/commits?author=piotrturski> authored
and PascalSchumacher
<https://github.com/apache/commons-io/commits?author=PascalSchumacher>
 committed on Dec 1, 2015

Gary

[1]
https://github.com/apache/commons-io/blob/3ad22fe3d689781a76a92908d0bbc119b2c68892/src/main/java/org/apache/commons/io/input/InfiniteCircularInputStream.java#L48-L49

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message