commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilles <gil...@harfang.homelinux.org>
Subject Re: svn commit: r1823550 - in /commons/proper/net/trunk/src: changes/changes.xml main/java/org/apache/commons/net/telnet/TelnetClient.java
Date Thu, 08 Feb 2018 12:08:40 GMT
Hi.

On Thu, 08 Feb 2018 11:55:10 -0000, sebb@apache.org wrote:
> Author: sebb
> Date: Thu Feb  8 11:55:10 2018
> New Revision: 1823550
>
> URL: http://svn.apache.org/viewvc?rev=1823550&view=rev
> Log:
> NET-643 NPE when closing telnet stream
>
> [...]
>
> Modified:
> 
> commons/proper/net/trunk/src/main/java/org/apache/commons/net/telnet/TelnetClient.java
> URL:
> 
> http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/telnet/TelnetClient.java?rev=1823550&r1=1823549&r2=1823550&view=diff
> 
> ==============================================================================
> ---
> 
> commons/proper/net/trunk/src/main/java/org/apache/commons/net/telnet/TelnetClient.java
> (original)
> +++
> 
> commons/proper/net/trunk/src/main/java/org/apache/commons/net/telnet/TelnetClient.java
> Thu Feb  8 11:55:10 2018
> @@ -100,10 +100,16 @@ public class TelnetClient extends Telnet
>
>      void _flushOutputStream() throws IOException
>      {
> +        if (_output_ == null) {
> +            throw new IOException("Stream closed");
> +        }
>          _output_.flush();
>      }
>      void _closeOutputStream() throws IOException
>      {
> +        if (_output_ == null) {
> +            return;
> +        }
>          try {
>              _output_.close();
>          } finally {

Why the difference in behaviour?
In the former case, "no-op" seems equally fine.

Gilles


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message