From dev-return-166034-archive-asf-public=cust-asf.ponee.io@commons.apache.org Sun Jan 14 16:48:02 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 9B81A180651 for ; Sun, 14 Jan 2018 16:48:02 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 8B06A160C43; Sun, 14 Jan 2018 15:48:02 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0373C160C1D for ; Sun, 14 Jan 2018 16:48:01 +0100 (CET) Received: (qmail 91612 invoked by uid 500); 14 Jan 2018 15:48:00 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 91599 invoked by uid 99); 14 Jan 2018 15:48:00 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 14 Jan 2018 15:48:00 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id DE4C0E030B; Sun, 14 Jan 2018 15:47:57 +0000 (UTC) From: shahabkondri To: dev@commons.apache.org Reply-To: dev@commons.apache.org Message-ID: Subject: [GitHub] commons-io pull request #54: Code cleanup Content-Type: text/plain Date: Sun, 14 Jan 2018 15:47:57 +0000 (UTC) GitHub user shahabkondri opened a pull request: https://github.com/apache/commons-io/pull/54 Code cleanup Simplified conditional expression. Remove duplicate exceptions and redundant throws clause. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shahabkondri/commons-io pullRequest Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-io/pull/54.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #54 ---- commit bba9cfb350e14b1922f48e366c7d5d0670937850 Author: shahab Date: 2018-01-14T14:53:46Z boolean expression can be simplified. commit 5addd24dcab871165a0689f240f662007a657c3b Author: shahab Date: 2018-01-14T15:01:35Z Conditional expression can be replaced by simpler expression. commit 5acf2d4c1ab4ff0928a252054c3ad1db33ba27d6 Author: shahab Date: 2018-01-14T15:03:32Z Conditional expression can be replaced by simpler expression. commit 4d921060135963cc89cad2011cb455d7ef59ee2d Author: shahab Date: 2018-01-14T15:09:54Z Conditional expression simplified. commit 69ad63307d94098357dda321b8e5dd2c2e1cfc17 Author: shahab Date: 2018-01-14T15:21:40Z Duplicate exceptions. IOException is in the throws list already. commit e3722716daa3902ac0564d6227a56bb2f994c05f Author: shahab Date: 2018-01-14T15:39:07Z Redundant throws clause - IOException is never thrown. ---- --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org