commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shahabkondri <...@git.apache.org>
Subject [GitHub] commons-io pull request #54: Code cleanup
Date Sun, 14 Jan 2018 15:47:57 GMT
GitHub user shahabkondri opened a pull request:

    https://github.com/apache/commons-io/pull/54

    Code cleanup

    Simplified conditional expression. Remove duplicate exceptions and redundant throws clause.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shahabkondri/commons-io pullRequest

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-io/pull/54.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #54
    
----
commit bba9cfb350e14b1922f48e366c7d5d0670937850
Author: shahab <shahab.kondri@...>
Date:   2018-01-14T14:53:46Z

    boolean expression can be simplified.

commit 5addd24dcab871165a0689f240f662007a657c3b
Author: shahab <shahab.kondri@...>
Date:   2018-01-14T15:01:35Z

    Conditional expression can be replaced by simpler expression.

commit 5acf2d4c1ab4ff0928a252054c3ad1db33ba27d6
Author: shahab <shahab.kondri@...>
Date:   2018-01-14T15:03:32Z

    Conditional expression can be replaced by simpler expression.

commit 4d921060135963cc89cad2011cb455d7ef59ee2d
Author: shahab <shahab.kondri@...>
Date:   2018-01-14T15:09:54Z

    Conditional expression simplified.

commit 69ad63307d94098357dda321b8e5dd2c2e1cfc17
Author: shahab <shahab.kondri@...>
Date:   2018-01-14T15:21:40Z

    Duplicate exceptions. IOException is in the throws list already.

commit e3722716daa3902ac0564d6227a56bb2f994c05f
Author: shahab <shahab.kondri@...>
Date:   2018-01-14T15:39:07Z

    Redundant throws clause - IOException is never thrown.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message