commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rob Tompkins <chtom...@gmail.com>
Subject Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1
Date Sat, 13 Jan 2018 15:56:40 GMT


> On Jan 11, 2018, at 7:25 PM, sebb <sebbaz@gmail.com> wrote:
> 
> On 11 January 2018 at 14:42, Rob Tompkins <chtompki@gmail.com> wrote:
>> If you do try to run it locally make sure you add
>> <dryRun>true</dryRun>
> 
> It would be useful to be able to define this on the command-line.

Bug found:

https://github.com/apache/commons-release-plugin/blob/master/src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionStagingMojo.java#L88
<https://github.com/apache/commons-release-plugin/blob/master/src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionStagingMojo.java#L88>

@Parameter(defaultValue = "false”)

should be:

@Parameter(property = "dryRun", defaultValue = "false”)

The intermediate workaround, like I emailed earlier, is:

<dryRun>${dryRun}</dryRun> in the configuration section.

-Rob

> 
>> To the configuration section of the plugin.
>> 
>>> On Jan 11, 2018, at 3:58 AM, Jörg Schaible <joerg.schaible@bpm-inspire.com>
wrote:
>>> 
>>> Am Wed, 10 Jan 2018 20:35:52 -0700 schrieb Gary Gregory:
>>> 
>>>> I wonder if:
>>>> - This should be a LAZY VOTE since this is not an official component but
>>>> rather a tool
>>> 
>>> +1
>>> 
>>>> - We should release it as 1.0 anyway (unless obvious bugs
>>>> are found) to avoid the chicken and egg problem: To really test this, I
>>>> want to create an RC for Commons Collection (for example). But that
>>>> means using a commons-release-plugin 1.0 version in my POM - which we
>>>> cannot release as a repeatable build since 1.0 is not out yet. And
>>>> cutting an RC with a 1.0-SNAPSHOT is not acceptable (not repeatable.)
>>> 
>>> we might release 1.0-RC1 (or 0.1) as Sergio suggested.
>>> 
>>> Cheers,
>>> Jörg
>>> 
>>> 
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>> 
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message