commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: [compress] TarArchiveEntry and Windows drive letter
Date Thu, 04 Jan 2018 15:12:29 GMT
On 2018-01-03, Torsten Curdt wrote:

> I just found a new issue with compress.

> It's the "normalizeFileName" in TarArchiveEntry again.
> On Windows it just strips the drive letter

> https://github.com/apache/commons-compress/blob/master/src/
> main/java/org/apache/commons/compress/archivers/tar/
> TarArchiveEntry.java#L1337

> which I think is a questionable default behaviour IMO.

>    TarArchiveEntry("C:\foo\bar") -> "/foo/bar"
>    TarArchiveEntry("D:\foo\bar") -> "/foo/bar"

"strip the drive letter" predates preserveLeadingSlashes

https://github.com/apache/commons-compress/commit/32eea1e611d66a3c1a6b1dc0b373a943614e5680#diff-b7b626a7d92545685d08e93834bfa3d0

triggered by

https://issues.apache.org/jira/browse/COMPRESS-26

and later

https://github.com/apache/commons-compress/commit/3e2ddad124ea6ab1bc690487793bf88560ca3732#diff-b7b626a7d92545685d08e93834bfa3d0

I could be convinced that we should only strip drive letters when we
don't preserve leading slashes either :-)

Usually tar archives do not contain absolute path names at all.

> Is that in line with how other unix tool ports handle things on windows?

No idea, really.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message