Return-Path: <dev-return-165434-archive-asf-public=cust-asf.ponee.io@commons.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 8EF81200D3A
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Wed, 15 Nov 2017 23:14:23 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 8D25A160BF4; Wed, 15 Nov 2017 22:14:23 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 08D64160BE4
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 15 Nov 2017 23:14:22 +0100 (CET)
Received: (qmail 7437 invoked by uid 500); 15 Nov 2017 22:14:22 -0000
Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@commons.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@commons.apache.org>
List-Post: <mailto:dev@commons.apache.org>
List-Id: <dev.commons.apache.org>
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Delivered-To: mailing list dev@commons.apache.org
Received: (qmail 7426 invoked by uid 99); 15 Nov 2017 22:14:21 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Nov 2017 22:14:21 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id B3FDEDFBC7; Wed, 15 Nov 2017 22:14:21 +0000 (UTC)
From: ansell <git@git.apache.org>
To: dev@commons.apache.org
Reply-To: dev@commons.apache.org
References: <git-pr-43-commons-rdf@git.apache.org>
In-Reply-To: <git-pr-43-commons-rdf@git.apache.org>
Subject: [GitHub] commons-rdf pull request #43: COMMONSRDF-49: Make AbstractRDFParser serializ...
Content-Type: text/plain
Message-Id: <20171115221421.B3FDEDFBC7@git1-us-west.apache.org>
Date: Wed, 15 Nov 2017 22:14:21 +0000 (UTC)
archived-at: Wed, 15 Nov 2017 22:14:23 -0000

Github user ansell commented on a diff in the pull request:

    https://github.com/apache/commons-rdf/pull/43#discussion_r151267617
  
    --- Diff: commons-rdf-simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java ---
    @@ -200,19 +200,19 @@
          *         been set
          */
         public Optional<IRI> getSourceIri() {
    -        return sourceIri;
    +        return Optional.ofNullable(sourceIri);
         }
     
    -    private Optional<RDF> rdfTermFactory = Optional.empty();
    -    private Optional<RDFSyntax> contentTypeSyntax = Optional.empty();
    -    private Optional<String> contentType = Optional.empty();
    -    private Optional<IRI> base = Optional.empty();
    -    private Optional<InputStream> sourceInputStream = Optional.empty();
    -    private Optional<Path> sourceFile = Optional.empty();
    -    private Optional<IRI> sourceIri = Optional.empty();
    +    private RDF rdfTermFactory = null;
    +    private RDFSyntax contentTypeSyntax = null;
    +    private String contentType = null;
    +    private IRI base = null;
    +    private InputStream sourceInputStream = null;
    --- End diff --
    
    This may be a sticking point for actually enabling ``Serializable``, but the changes to not use optional field values look good to me.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org