commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kinow <...@git.apache.org>
Subject [GitHub] commons-collections issue #33: [COLLECTIONS-664] Add a class that extend a l...
Date Mon, 06 Nov 2017 10:06:28 GMT
Github user kinow commented on the issue:

    https://github.com/apache/commons-collections/pull/33
  
    Hi @zhangminglei !
    
    Sure. Few questions from reviewing the JIRA ticket and the pull request.
    
    * Why Commons Collections? The SortedProperties uses Java collection classes to sort its
keys. But FileProperties doesn't seem to have much to do with Java collections.
    * The name of the class doesn't really suggest what it does. Unless there are other use
cases, we could be more specific about the class name.
    * However, I suspect this code belongs more to the user code, and not really to the low
level library. Might be better to update the ticket to Commons Configuration maybe (?), and
send a message to the development mailing list in case you don't hear back within some days.
    
    The code is well written, and with tests :-) we just need to review the use case, and
which component could host it.
    
    Hope it helps
    Bruno


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message