Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
MIME-Version: 1.0
In-Reply-To: <8D2FF39A-DFCD-4B1E-A506-1E6DF709D2EF@apache.org>
References: <CACZkXPyVJ+MsTpEfaRspZE-bCC5viHD4FfLKTs268hCZYxah_g@mail.gmail.com>
 <CACZkXPwasziGvDxot3DNiknKomD65ukyk8v+gZGqA+mMRwyK9g@mail.gmail.com>
 <CACZkXPxE1wV62AQRv=je9o70jGtjET25Q3jfWftbPNX6XfYvLQ@mail.gmail.com>
 <CACZkXPyRYejUwvZM+svmOtVgLWftOR82HsF1xUCUogKn7b34dA@mail.gmail.com>
 <CACZkXPziHKq-u0gqQKr5eO958k=NFozuKXQG4Z3mkaV91sJm=w@mail.gmail.com>
 <CACZkXPw=5zJ=Ox-Q-XCoKmax17h49QJay3uZ25SWX-m3zVJQ8w@mail.gmail.com>
 <1372189625.6903078.1509249280575@mail.yahoo.com> <8D2FF39A-DFCD-4B1E-A506-1E6DF709D2EF@apache.org>
From: Gary Gregory <garydgregory@gmail.com>
Date: Mon, 30 Oct 2017 18:54:14 -0600
Message-ID: <CACZkXPw2r8Ds=ZRew61FcsMg0k97CBfR6W0o6vROGObr21H+fQ@mail.gmail.com>
Subject: Re: [dbcp] update to pool 2.4.3.
To: Commons Developers List <dev@commons.apache.org>
Content-Type: multipart/alternative; boundary="001a1144db3ab31d37055ccd31ea"
archived-at: Tue, 31 Oct 2017 00:54:26 -0000

--001a1144db3ab31d37055ccd31ea
Content-Type: text/plain; charset="UTF-8"

On Sun, Oct 29, 2017 at 2:09 AM, Mark Thomas <markt@apache.org> wrote:

> On 29 October 2017 03:54:40 GMT+00:00, "Bruno P. Kinoshita" <
> brunodepaulak@yahoo.com.br.INVALID> wrote:
> >Hi Gary,
> >
> >Started the tests in Maven command line, found which tests failed.
> >Executed the tests in Eclipse, found which class was related to the
> >failure. Then did a diff between both tags.
> >
> >git diff POOL_2_4_2 POOL_2.4.3-RC1 --
> >./src/main/java/org/apache/commons/pool2/impl/DefaultPooledObject.java
> >
> >The short diff indicates that the failures started possibly due to the
> >replacement of Exceptions in the DefaultPooledObject by a CallStack.
> >Looks like the CallStack does not keep track of all the methods called
> >(due to a security context manager from what I could tell?). Only
> >classes.
> >
> >The following pull request updates pool to 2.4.3, and changes the unit
> >tests to, instead of looking for method names in the log writer output,
> >to look for the test class name.
> >
> >    https://github.com/apache/commons-dbcp/pull/8
> >
> >
> >Feel free to review and merge if you agree it's a good solution.
>
> I'm not sure it is a good solution. I need to look at what is going on in
> more detail but if the method information has been lost then that will make
> tracking down the root cause of a pool leak much, much harder.
>

That we know that 2.4.3 does not provide method information compared to
2.4.2, I propose:

- Adapt the dbcp test to this new behavior, then release dbcp 2.2.0.
- Wait for Matt's fix to [poo], release [pool] 2.5.0 (and 2.4.4 if Matt
feels like providing a patch there as well.)
- Update dbcp again to test both the old and new call stack formats.
- Release dbcp 2.2.1

Thoughts?

Gary


> Mark
>
>
> >Hope that helps,
> >Bruno
> >
> >ps: I think we need to publish the commons-pool website. Tried to have
> >a look at the changes report for 2.4.3 but it wasn't there yet.
> >ps2: I'm currently looking at those trivial checkstyle issues that we
> >found during the vote thread. Going to send another pull request for
> >that today
> >
> >
> >
> >________________________________
> >From: Gary Gregory <garydgregory@gmail.com>
> >To: Commons Developers List <dev@commons.apache.org>
> >Sent: Sunday, 29 October 2017 8:44 AM
> >Subject: [dbcp] update to pool 2.4.3.
> >
> >
> >
> >Hi All,
> >
> >
> >After updating dbcp to 2.4.3 I am seeing two unit test failures. I have
> >to
> >
> >step out for the day and I am hoping someone can help figure out what
> >is
> >
> >going on.
> >
> >
> >Gary
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >For additional commands, e-mail: dev-help@commons.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

--001a1144db3ab31d37055ccd31ea--