Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Date: Sun, 29 Oct 2017 08:09:09 +0000
User-Agent: K-9 Mail for Android
In-Reply-To: <1372189625.6903078.1509249280575@mail.yahoo.com>
References: <CACZkXPyVJ+MsTpEfaRspZE-bCC5viHD4FfLKTs268hCZYxah_g@mail.gmail.com> <CACZkXPwasziGvDxot3DNiknKomD65ukyk8v+gZGqA+mMRwyK9g@mail.gmail.com> <CACZkXPxE1wV62AQRv=je9o70jGtjET25Q3jfWftbPNX6XfYvLQ@mail.gmail.com> <CACZkXPyRYejUwvZM+svmOtVgLWftOR82HsF1xUCUogKn7b34dA@mail.gmail.com> <CACZkXPziHKq-u0gqQKr5eO958k=NFozuKXQG4Z3mkaV91sJm=w@mail.gmail.com> <CACZkXPw=5zJ=Ox-Q-XCoKmax17h49QJay3uZ25SWX-m3zVJQ8w@mail.gmail.com> <1372189625.6903078.1509249280575@mail.yahoo.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [dbcp] update to pool 2.4.3.
To: Commons Developers List <dev@commons.apache.org>
From: Mark Thomas <markt@apache.org>
Message-ID: <8D2FF39A-DFCD-4B1E-A506-1E6DF709D2EF@apache.org>
archived-at: Sun, 29 Oct 2017 08:09:05 -0000

On 29 October 2017 03:54:40 GMT+00:00, "Bruno P=2E Kinoshita" <brunodepaula=
k@yahoo=2Ecom=2Ebr=2EINVALID> wrote:
>Hi Gary,
>
>Started the tests in Maven command line, found which tests failed=2E
>Executed the tests in Eclipse, found which class was related to the
>failure=2E Then did a diff between both tags=2E
>
>git diff POOL_2_4_2 POOL_2=2E4=2E3-RC1 --
>=2E/src/main/java/org/apache/commons/pool2/impl/DefaultPooledObject=2Ejav=
a
>
>The short diff indicates that the failures started possibly due to the
>replacement of Exceptions in the DefaultPooledObject by a CallStack=2E
>Looks like the CallStack does not keep track of all the methods called
>(due to a security context manager from what I could tell?)=2E Only
>classes=2E
>
>The following pull request updates pool to 2=2E4=2E3, and changes the uni=
t
>tests to, instead of looking for method names in the log writer output,
>to look for the test class name=2E
>
>    https://github=2Ecom/apache/commons-dbcp/pull/8
>
>
>Feel free to review and merge if you agree it's a good solution=2E

I'm not sure it is a good solution=2E I need to look at what is going on i=
n more detail but if the method information has been lost then that will ma=
ke tracking down the root cause of a pool leak much, much harder=2E

Mark


>Hope that helps,
>Bruno
>
>ps: I think we need to publish the commons-pool website=2E Tried to have
>a look at the changes report for 2=2E4=2E3 but it wasn't there yet=2E
>ps2: I'm currently looking at those trivial checkstyle issues that we
>found during the vote thread=2E Going to send another pull request for
>that today
>
>
>
>________________________________
>From: Gary Gregory <garydgregory@gmail=2Ecom>
>To: Commons Developers List <dev@commons=2Eapache=2Eorg>=20
>Sent: Sunday, 29 October 2017 8:44 AM
>Subject: [dbcp] update to pool 2=2E4=2E3=2E
>
>
>
>Hi All,
>
>
>After updating dbcp to 2=2E4=2E3 I am seeing two unit test failures=2E I =
have
>to
>
>step out for the day and I am hoping someone can help figure out what
>is
>
>going on=2E
>
>
>Gary
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@commons=2Eapache=2Eorg
>For additional commands, e-mail: dev-help@commons=2Eapache=2Eorg


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org