commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From BruceKuiLiu <...@git.apache.org>
Subject [GitHub] commons-io pull request #45: Fix the ignored exceptional return value by add...
Date Mon, 09 Oct 2017 16:33:57 GMT
GitHub user BruceKuiLiu opened a pull request:

    https://github.com/apache/commons-io/pull/45

    Fix the ignored exceptional return value by adding an IfStatement to …

    …check the return value.
    
    This statement returns a value that is not checked.
    The return value should be checked since it can indicate an unusual or unexpected function
execution.
    The statement returns false if the destination directory could not be successfully created
(rather than throwing an Exception).
    If you don't check the result, you won't notice if the statement signals an unexpected
behavior by returning an atypical return value.
    http://findbugs.sourceforge.net/bugDescriptions.html#RV_RETURN_VALUE_IGNORED_BAD_PRACTICE

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BruceKuiLiu/commons-io master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-io/pull/45.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #45
    
----

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message