commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From PascalSchumacher <...@git.apache.org>
Subject [GitHub] commons-collections issue #29: Added unit tests to increase code coverage
Date Thu, 12 Oct 2017 08:23:08 GMT
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-collections/pull/29
  
    `assertEquals(MapUtils.getDouble(in,"key", 0.0), 2.0, 0);` etc. should be `assertEquals(2.0,
MapUtils.getDouble(in,"key", 0.0), 0);` because it is `assertEquals(double expected, double
actual, double delta)`
    
    Also two test fail for locales that do no use `.` as the decimal separator (e.g. germany)
    
    ```
    Failed tests:
      MapUtilsTest.testgetDoubleValue:956 expected:<20.0> but was:<2.0>
      MapUtilsTest.testgetFloatValue:974 expected:<20.0> but was:<2.0>
    ```



---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message