commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Matèrne (jhm) <apa...@materne.de>
Subject AW: [LANG] Releasing 3.6.1
Date Wed, 06 Sep 2017 11:15:33 GMT
Using RandomStringGenerator from RandomStringUtils sounds good, but implies adding 
a dependency to commons-lang (commons-text).
At the moment the only dependencies are for testing [1].

I am more of a -0 about adding the dependency, because this implies that all projects using
commons-lang have to deliver commons-text too.
Optional dependencies seem to be a solution, but [2] shows that these dependencies should
be avoided if possible.

Jan

[1] https://github.com/apache/commons-lang/blob/master/pom.xml
[2] https://maven.apache.org/guides/introduction/introduction-to-optional-and-excludes-dependencies.html



> -----Ursprüngliche Nachricht-----
> Von: Amey Jadiye [mailto:ameyjadiye@gmail.com]
> Gesendet: Mittwoch, 6. September 2017 09:34
> An: Commons Developers List
> Betreff: Re: [LANG] Releasing 3.6.1
> 
> Hi Rob,
> 
> Looking at frequency I think more number of requests coming for
> RandomStringUtils for its simplicity.
> 
>  RandomStringGenerator is strong , flexible but one can't use it
> quickly.
> Also I think this tool should belong in Commons text's arsenal. I'm not
> only moving RandomStringUtils  to text but changing its core logic with
> using RandomStringGenerator which seems fair to me. So finally we
> should release
> text-1.2 rather doing rollback of deprecation and release lang 3.6.1,
> WDYT ?
> 
> Regards,
> Amey
> 
> On Wed, Sep 6, 2017, 12:00 AM Rob Tompkins <chtompki@gmail.com> wrote:
> 
> >
> > > On Sep 5, 2017, at 11:00 AM, Amey Jadiye <ameyjadiye@gmail.com>
> wrote:
> > >
> > > Hello Benedikt,
> > >
> > > How about we keep that deprecated in lang and release Text-1.2 ?
> > [snip]
> >
> > I’m on board with this if folks are complaining and the original
> > intent was to deprecate things in [lang]. Why not roll forward as
> > opposed to backwards?
> >
> > But, that opens the question: Is RandomStringUtils something that
> most
> > folks would want (i.e. should it be in [lang] or [text])? I think
> that
> > question is more the heart of the problem here. Either direction
> seems
> > reasonable to me.
> >
> > Thoughts?
> >
> > -Rob
> >
> > > I will
> > > submit changes [1] related to this in fact i'm fixing couple of
> > > failing test cases ATM. If you are planning to release 3.6.1 just
> to
> > > remove deprecation and  deprecate RandomStringUtils back in Lang -
> > > 3.7 I'm fine with that as well.
> > >
> > > [1]. https://issues.apache.org/jira/browse/TEXT-101
> > >
> > > On Tue, Sep 5, 2017 at 10:47 AM, Benedikt Ritter
> > > <britter@apache.org>
> > wrote:
> > >
> > >> Hi,
> > >>
> > >> since we’re getting more and more requests about the deprecation
> of
> > >> RandomStringUtils, I’m thinking about releasing the current state
> > >> of the master branch as 3.6.1. I may have time to push an RC
> > >> sometime this
> > week.
> > >> So if you have some fixes you want to include, please do so now.
> > >>
> > >> Regards,
> > >> Benedikt
> > >> ------------------------------------------------------------------
> -
> > >> -- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > >> For additional commands, e-mail: dev-help@commons.apache.org
> > >>
> > >>
> > >
> > >
> > > --
> > >
> > > -------------------------------------------------------------------
> -
> > > -
> > >
> > > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > >
> > > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message