Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0EF6B200CF1 for ; Mon, 28 Aug 2017 20:58:15 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 0D6651656C3; Mon, 28 Aug 2017 18:58:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 79D471656C1 for ; Mon, 28 Aug 2017 20:58:14 +0200 (CEST) Received: (qmail 69979 invoked by uid 500); 28 Aug 2017 18:58:13 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 69967 invoked by uid 99); 28 Aug 2017 18:58:13 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Aug 2017 18:58:13 +0000 Received: from benedikts-mbp.local (dslb-088-072-184-165.088.072.pools.vodafone-ip.de [88.72.184.165]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id 7CB451A0029 for ; Mon, 28 Aug 2017 18:58:12 +0000 (UTC) From: Benedikt Ritter Content-Type: multipart/alternative; boundary="Apple-Mail=_947A7CF1-33B2-44C4-ABEE-329FA46989D0" Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: [BCEL] Breaking changes in 6.1 needed by Tomcat (?) Message-Id: Date: Mon, 28 Aug 2017 20:58:09 +0200 To: Commons Developers List X-Mailer: Apple Mail (2.3273) archived-at: Mon, 28 Aug 2017 18:58:15 -0000 --Apple-Mail=_947A7CF1-33B2-44C4-ABEE-329FA46989D0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hi, Rev. 1782852 [1] has introduced two breaking changes by adding the = methods: public void visitAnnotation(org.apache.bcel.classfile.Annotations) public void = visitAnnotationDefault(org.apache.bcel.classfile.AnnotationDefault) to the interface org.apache.bcel.classfile.Visitor. The commit comment = indicates that these changes are needed by the Tomcat project. How do we = want to deal with this for the upcoming 6.1 release? I see several = options: - accept these changes and make it explicit in release notes - add a new interface which extends from the Visitor interface and add = the new methods to that interface - major version bump (probably not the best idea=E2=80=A6) Thoughts? Benedikt [1] http://svn.apache.org/viewvc?view=3Drevision&revision=3D1782852 = = --Apple-Mail=_947A7CF1-33B2-44C4-ABEE-329FA46989D0--