Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
MIME-Version: 1.0
In-Reply-To: <CDF3153C-E189-48E7-A1E1-14DBE3CD5420@apache.org>
References: <CDF3153C-E189-48E7-A1E1-14DBE3CD5420@apache.org>
From: Gary Gregory <garydgregory@gmail.com>
Date: Mon, 28 Aug 2017 13:07:47 -0600
Message-ID: <CACZkXPymUKdAH00WTF2yJEnq-2DS-xtEespGK8WYVrAS-Lczhw@mail.gmail.com>
Subject: Re: [BCEL] Breaking changes in 6.1 needed by Tomcat (?)
To: Commons Developers List <dev@commons.apache.org>
Content-Type: multipart/alternative; boundary="001a113ed538af06a60557d50244"
archived-at: Mon, 28 Aug 2017 19:07:52 -0000

--001a113ed538af06a60557d50244
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

The question is whether this breaks binary compatibility. If it does, this
needs fixing. Unless there are other important changes that warrant a major
version, I would go the sub-interface route; ugly, but workable within the
same major release.

Gary

On Mon, Aug 28, 2017 at 12:58 PM, Benedikt Ritter <britter@apache.org>
wrote:

> Hi,
>
> Rev. 1782852 [1] has introduced two breaking changes by adding the method=
s:
>
> public void visitAnnotation(org.apache.bcel.classfile.Annotations)
> public void visitAnnotationDefault(org.apache.bcel.classfile.
> AnnotationDefault)
>
> to the interface org.apache.bcel.classfile.Visitor. The commit comment
> indicates that these changes are needed by the Tomcat project. How do we
> want to deal with this for the upcoming 6.1 release? I see several option=
s:
>
> - accept these changes and make it explicit in release notes
> - add a new interface which extends from the Visitor interface and add th=
e
> new methods to that interface
> - major version bump (probably not the best idea=E2=80=A6)
>
> Thoughts?
> Benedikt
>
> [1] http://svn.apache.org/viewvc?view=3Drevision&revision=3D1782852 <
> http://svn.apache.org/viewvc?view=3Drevision&revision=3D1782852>

--001a113ed538af06a60557d50244--