Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
From: Rob Tompkins <chtompki@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: Release Commons Jelly 1.0.1 Based on RC2
Date: Wed, 30 Aug 2017 08:39:03 -0400
References: <A78AD868-C2CB-44F9-A325-C793D3D73356@apache.org>
 <1474900932.147034.1504070539566@mail.yahoo.com>
To: Commons Developers List <dev@commons.apache.org>,
 "Bruno P. Kinoshita" <brunodepaulak@yahoo.com.br>
In-Reply-To: <1474900932.147034.1504070539566@mail.yahoo.com>
Message-Id: <9D2AD35B-F404-4D7D-848E-6FFB4F4F912B@gmail.com>
archived-at: Wed, 30 Aug 2017 12:39:08 -0000


> On Aug 30, 2017, at 1:22 AM, Bruno P. Kinoshita =
<brunodepaulak@yahoo.com.br.INVALID> wrote:
>=20
> Hi Rob,
> Thanks for RM'ing Commons Jelly 1.0.1. Here's my initial tests =
results:
>=20
> Downloaded JDK from Oracle archives, version 5.0u22.
>=20
> Then downloaded Apache Ant following what was in the Dockerfile.
>=20
>     curl =
http://archive.apache.org/dist/ant/binaries/apache-ant-1.6.0-bin.tar.gz =
-o /tmp/apache-ant-1.6.0-bin.tar.gz
>=20
> And installed it to /opt.
>=20
> Downloaded JUnit into Apache Ant's libraries folder.
>=20
>     curl =
https://search.maven.org/remotecontent?filepath=3Djunit/junit/3.8.1/junit-=
3.8.1.jar -o /opt/apache-ant-1.6.0/lib/junit-3.8.1.jar
>=20
> And downloaded other dependencies as in the Dockerfile/build.xml.
>=20
>     curl =
https://search.maven.org/remotecontent?filepath=3Djavax/servlet/servlet-ap=
i/2.3/servlet-api-2.3.jar -o =
/${HOME}/.maven/repository/servletapi/jars/servletapi-2.3.jar
> curl =
https://search.maven.org/remotecontent?filepath=3Dcommons-cli/commons-cli/=
1.0/commons-cli-1.0.jar -o =
/${HOME}/.maven/repository/commons-cli/jars/commons-cli-1.0.jar
> curl =
https://search.maven.org/remotecontent?filepath=3Dcommons-lang/commons-lan=
g/2.0/commons-lang-2.0.jar -o =
/${HOME}/.maven/repository/commons-lang/jars/commons-lang-2.0.jar
> curl =
https://search.maven.org/remotecontent?filepath=3Dcommons-discovery/common=
s-discovery/20030211.213356/commons-discovery-20030211.213356.jar -o =
/${HOME}/.maven/repository/commons-discovery/jars/commons-discovery-200302=
11.213356.jar
> curl =
https://search.maven.org/remotecontent?filepath=3Dforehead/forehead/1.0-be=
ta-5/forehead-1.0-beta-5.jar -o =
/${HOME}/.maven/repository/forehead/jars/forehead-1.0-beta-5.jar
> curl =
https://search.maven.org/remotecontent?filepath=3Djavax/servlet/jstl/1.0.6=
/jstl-1.0.6.jar -o /${HOME}/.maven/repository/jstl/jars/jstl-1.0.6.jar
> curl =
https://search.maven.org/remotecontent?filepath=3Djunit/junit/3.8.1/junit-=
3.8.1.jar -o /${HOME}/.maven/repository/junit/jars/junit-3.8.1.jar
> curl =
https://search.maven.org/remotecontent?filepath=3Dcommons-jexl/commons-jex=
l/1.0/commons-jexl-1.0.jar -o =
/${HOME}/.maven/repository/commons-jexl/jars/commons-jexl-1.0.jar
> curl =
https://search.maven.org/remotecontent?filepath=3Dxml-apis/xml-apis/1.0.b2=
/xml-apis-1.0.b2.jar -o =
/${HOME}/.maven/repository/xml-apis/jars/xml-apis-1.0.b2.jar
> curl =
https://search.maven.org/remotecontent?filepath=3Dcommons-beanutils/common=
s-beanutils/1.6/commons-beanutils-1.6.jar -o =
/${HOME}/.maven/repository/commons-beanutils/jars/commons-beanutils-1.6.ja=
r
> curl =
https://search.maven.org/remotecontent?filepath=3Dcommons-collections/comm=
ons-collections/2.1/commons-collections-2.1.jar -o =
/${HOME}/.maven/repository/commons-collections/jars/commons-collections-2.=
1.jar
> curl =
https://search.maven.org/remotecontent?filepath=3Dcommons-logging/commons-=
logging/1.0.3/commons-logging-1.0.3.jar -o =
/${HOME}/.maven/repository/commons-logging/jars/commons-logging-1.0.3.jar
> curl =
https://search.maven.org/remotecontent?filepath=3Ddom4j/dom4j/1.5.2/dom4j-=
1.5.2.jar -o /${HOME}/.maven/repository/dom4j/jars/dom4j-1.5.2.jar
> curl =
https://search.maven.org/remotecontent?filepath=3Djaxen/jaxen/1.1-beta-4/j=
axen-1.1-beta-4.jar -o =
/${HOME}/.maven/repository/jaxen/jars/jaxen-1.1-beta-4.jar
> curl =
https://search.maven.org/remotecontent?filepath=3Dxerces/xercesImpl/2.2.1/=
xercesImpl-2.2.1.jar -o =
/${HOME}/.maven/repository/xerces/jars/xerces-2.2.1.jar
>=20
> Then started the build with Apache Ant.
>=20
>     /opt/apache-ant-1.6.0/bin/ant
>=20
> Build succeeds, jar is created successfully.
>=20
> ```
> test:
>=20
> jar:
>       [jar] Building jar: =
/home/kinow/Development/java/workspace/commons-jelly-1.0.1-RC2/target/comm=
ons-jelly-1.0.1.jar
>=20
> BUILD SUCCESSFUL
> Total time: 21 seconds
>=20
> ```
>=20
> Then had a look at the SVN changes with `svn diff -r1805850 | less`, =
everything looks OK too.
>=20
> Manually iterated through each JUnit XML report, everything looking =
OK. The TestDoctypeDefinitionXXE succeeded, with some errors in the =
stderr output, but I assume the error messages are normal and the =
assertions were correctly executed.
>=20
> Checked signatures (KEYS file already imported):
>     wget -r -nH -nd -np -R index.html*  -erobots=3Doff  =
https://repository.apache.org/content/repositories/orgapachecommons-1260/c=
ommons-jelly/commons-jelly/1.0.1/    for jar in *.jar ; do gpg --verify =
"${jar}".asc; done
>=20
> All good.
>=20
> Minor issues, not sure if any of these are blockers?
>=20
> 1)
> RELEASE-NOTES.txt mentions The Jakarta Commons Jelly team, but I think =
it could be The Apache Commons Jelly team. The URL is also set to =
jakarta.apache, but there's some server redirect in place already.
> 2)
>=20
>> Details of changes since 1.0 are in the release notes:> =
https://dist.apache.org/repos/dist/dev/commons/jelly/RELEASE-NOTES.txt
> 404 for this URL. Maybe it was overwritten when generating the dist =
files? I can still check the RELEASE-NOTES in the tag, so I think it's =
OK.
>=20
> 3)
> commons-jelly-1.0.1-bin.zip
> In the dist area, contains a __MACOSX folder. The .tar.gz does not. I =
assume this happens when we create a ZIP in MacOS?
>=20
>   [ X ] +0 OK, but=E2=80=A6

I=E2=80=99m not opposed to a re-roll of the release because of these =
issues. The manual nature of it made it a tad overwhelming keeping track =
of all of the changes that I needed to make, and I tend to err on the =
side of minimal change. So, seeing the RELEASE-NOTES.txt issues I=E2=80=99=
m ok with making another go at it.=20

Thoughts everyone?

-Rob

>=20
> The only issue that concerns me a bit is the ZIP with the Mac OS =
folder... But if none of these are blockers then I'll update my vote to =
+1!=20
>=20
> Thanks!Bruno
>=20
> ________________________________
> From: Rob Tompkins <chtompki@apache.org>
> To: Commons Developers List <dev@commons.apache.org>
> Sent: Wednesday, 30 August 2017, 2:18:26 AM NZST
> Subject: Release Commons Jelly 1.0.1 Based on RC2
>=20
> Hello,
>=20
> Commons Jelly 1.0.1 R2 is available for review here:
>   https://dist.apache.org/repos/dist/dev/commons/jelly (svn revision =
21342)
>=20
> Note, if anyone needs to get an environment for building and testing =
the release candidate, I have created a docker container such that if =
you are currently in the project directory you can run "docker run -it =
-v $(pwd):/root/commons-jelly-1.X chtompki/commons-jelly-build-env =
bash=E2=80=9D then =E2=80=9Ccd /root/commons-jelly-1.X=E2=80=9D to get =
to a runnable place for the project. The container comes with JDK =
1.5.0_22-b03 and Ant 1.6.0 on the path. If there are any questions about =
how to use this let me know.
>=20
> The tag is here:
>   =
https://svn.apache.org/repos/asf/commons/proper/jelly/tags/commons-jelly-1=
.0.1-RC2
>=20
> Commit the tag points at:
>   1806595
>=20
> Maven Artifacts:
>   =
https://repository.apache.org/content/repositories/orgapachecommons-1260
>=20
> These are the Maven artifacts and their hashes:
>=20
> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-javadoc.jar
> =
<https://repository.apache.org/content/repositories/orgapachecommons-1260/=
commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-javadoc.jar>
> (SHA1: 3f4cfaccff8c8448f216c60c428dbd2eff7b2313)
> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-sources.jar.asc
> =
<https://repository.apache.org/content/repositories/orgapachecommons-1260/=
commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-sources.jar.asc>
> (SHA1: 2cb35149c8fa3b26af9684abeeb0d7e7655e18f9)
> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.pom.asc
> =
<https://repository.apache.org/content/repositories/orgapachecommons-1260/=
commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.pom.asc>
> (SHA1: 572e91a206c52ac5c51834e0186a53c9de8246b3)
> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.pom
> =
<https://repository.apache.org/content/repositories/orgapachecommons-1260/=
commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.pom>
> (SHA1: 65333d0abdce02b3ae3a54c513c19b7aa04749ba)
> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.jar.asc
> =
<https://repository.apache.org/content/repositories/orgapachecommons-1260/=
commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.jar.asc>
> (SHA1: f0154dc77befe4f89141a3806e43967869a29ef5)
> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-javadoc.jar.asc
> =
<https://repository.apache.org/content/repositories/orgapachecommons-1260/=
commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-javadoc.jar.asc>
> (SHA1: ec4465d236ba78415eb6a7aea44b197d5f643934)
> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-sources.jar
> =
<https://repository.apache.org/content/repositories/orgapachecommons-1260/=
commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-sources.jar>
> (SHA1: 939a76c00db4ea2463fe57e708299a5a989087e2)
> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.jar
> =
<https://repository.apache.org/content/repositories/orgapachecommons-1260/=
commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.jar>
> (SHA1: da868784b796b2c20e5e645ed2739f38c5b74454)
> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-tests.jar.asc
> =
<https://repository.apache.org/content/repositories/orgapachecommons-1260/=
commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-tests.jar.asc>
> (SHA1: f0117a1f2b32164e1edcd54188ffe232e0304d7f)
> =
/commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-test-sources.jar.as=
c
> =
<https://repository.apache.org/content/repositories/orgapachecommons-1260/=
commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-test-sources.jar.asc=
>
> (SHA1: ae1175942a746bf3e40176a3089edb2f2fd89e43)
> =
/commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-test-sources.jar
> =
<https://repository.apache.org/content/repositories/orgapachecommons-1260/=
commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-test-sources.jar>
> (SHA1: b6459e04b66bce00d7b230eef3fa5fefc160ccc1)
> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-tests.jar
> =
<https://repository.apache.org/content/repositories/orgapachecommons-1260/=
commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-tests.jar>
> (SHA1: e7f7c80dbb05472fcd211a5c726b554ecab02770)
>=20
> I have tested this with JDK 1.5.0_22-b03 using Ant 1.6.0.
>=20
> Details of changes since 1.0 are in the release notes:
>     =
https://dist.apache.org/repos/dist/dev/commons/jelly/RELEASE-NOTES.txt
>=20
> Site:
>       I have no site as this was generated with ant. My plan was to =
simply make minimal=20
>       changes to the existant site for the purpose of documenting the =
patch.
>=20
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>=20
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now,
> i.e. sometime after 14:20 (UTC) 1-September 2017
>=20
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>=20
> Thanks!
> Rob
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org