Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
From: kinow <git@git.apache.org>
To: dev@commons.apache.org
Reply-To: dev@commons.apache.org
References: <git-pr-18-commons-imaging@git.apache.org>
In-Reply-To: <git-pr-18-commons-imaging@git.apache.org>
Subject: [GitHub] commons-imaging pull request #18: IMAGING-168 installing package with Swedis...
Content-Type: text/plain
Message-Id: <20170806110339.8BE31F1820@git1-us-west.apache.org>
Date: Sun,  6 Aug 2017 11:03:39 +0000 (UTC)
archived-at: Sun, 06 Aug 2017 11:03:41 -0000

Github user kinow commented on a diff in the pull request:

    https://github.com/apache/commons-imaging/pull/18#discussion_r131540224
  
    --- Diff: src/main/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcParser.java ---
    @@ -248,6 +258,35 @@ public PhotoshopApp13Data parsePhotoshopSegment(final byte[] bytes,
             return elements;
         }
     
    +    private String getEncodingCharsetName(byte[] codedCharacterSet){
    +        final Character WHITESPACE = ' ';
    +        String codedCharacterSetString = new String(codedCharacterSet);
    +        try {
    +            if (Charset.isSupported(codedCharacterSetString)) {
    +                return codedCharacterSetString;
    +            }
    +        }catch (IllegalCharsetNameException e){
    +
    --- End diff --
    
    Might be worth to add at least one comment saying why these exceptions are not important, and that can be safely ignored.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org