commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kinow <...@git.apache.org>
Subject [GitHub] commons-imaging pull request #30: add-tests
Date Sun, 06 Aug 2017 09:55:30 GMT
Github user kinow commented on a diff in the pull request:

    https://github.com/apache/commons-imaging/pull/30#discussion_r131538871
  
    --- Diff: src/test/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegXmpParserTest.java
---
    @@ -1,3 +1,19 @@
    +/*
    --- End diff --
    
    Great catch on the missing licence headers! As I'm adding comments to this PR, and I'm
just passing by the component to see if it supports something that I need for a project -
and am not really familiar with the code base. It may take a bit longer to merge this PR.
But if you submit another one just for the headers, we can merge it pretty much immediately
;-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message