Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
MIME-Version: 1.0
In-Reply-To: <CAPMys86z7EWSCFnbV8j4uwmJ4b30tpmQj2c1uEuFkNRq0PCFRg@mail.gmail.com>
References: <CAPMys86z7EWSCFnbV8j4uwmJ4b30tpmQj2c1uEuFkNRq0PCFRg@mail.gmail.com>
From: Matt Sicker <boards@gmail.com>
Date: Wed, 5 Jul 2017 10:42:09 -0500
Message-ID: <CACmp6kpcFjXgwxOYqgdFReZC05CNKkG_2o4pvVn_3tDQ2ROY=g@mail.gmail.com>
Subject: Re: [lang] Applying IntelliJ IDEA refactorings
To: Commons Developers List <dev@commons.apache.org>
Content-Type: multipart/alternative; boundary="001a114b1850db7965055393d729"
archived-at: Wed, 05 Jul 2017 15:42:27 -0000

--001a114b1850db7965055393d729
Content-Type: text/plain; charset="UTF-8"

I like the idea myself at least, though I'm not sure if it conflicts with
any coding styleguides established.

On 4 July 2017 at 18:18, Jonathan Bluett-Duncan <jbluettduncan@gmail.com>
wrote:

> Hi all,
>
> I'm interested in going through commons-lang with IntelliJ IDEA and
> applying small refactorings to make the code base easier to read and/or
> more performant (and also make IntelliJ IDEA itself report less warnings).
>
> Is this something that the [lang] team would find useful?
>
> Examples of refactorings that I could apply include:
>
>    - Replace manual array-to-collection copy operations with
>    `Collections.addAll()`.
>    - Replace simple `String{Buffer,Builder}` usages with direct `String`
>    concatenations or `String.format()`.
>    - Simplifying boolean expressions like `obj instanceof CharRange ==
>    false` to `!(obj instanceof CharRange)`.
>
>
> Cheers,
> Jonathan
>


-- 
Matt Sicker <boards@gmail.com>

--001a114b1850db7965055393d729--