Return-Path: <dev-return-163775-archive-asf-public=cust-asf.ponee.io@commons.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 0B26C200CCF
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Mon, 24 Jul 2017 19:35:40 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 095AB163AF8; Mon, 24 Jul 2017 17:35:40 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 5120E163AF6
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 24 Jul 2017 19:35:39 +0200 (CEST)
Received: (qmail 58438 invoked by uid 500); 24 Jul 2017 17:35:38 -0000
Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@commons.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@commons.apache.org>
List-Post: <mailto:dev@commons.apache.org>
List-Id: <dev.commons.apache.org>
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Delivered-To: mailing list dev@commons.apache.org
Received: (qmail 58416 invoked by uid 99); 24 Jul 2017 17:35:38 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Jul 2017 17:35:38 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id E3105DFC25; Mon, 24 Jul 2017 17:35:37 +0000 (UTC)
From: ameyjadiye <git@git.apache.org>
To: dev@commons.apache.org
Reply-To: dev@commons.apache.org
References: <git-pr-57-commons-text@git.apache.org>
In-Reply-To: <git-pr-57-commons-text@git.apache.org>
Subject: [GitHub] commons-text pull request #57: TEXT-98: Remove isDelimiter and use HashSets ...
Content-Type: text/plain
Message-Id: <20170724173537.E3105DFC25@git1-us-west.apache.org>
Date: Mon, 24 Jul 2017 17:35:37 +0000 (UTC)
archived-at: Mon, 24 Jul 2017 17:35:40 -0000

Github user ameyjadiye commented on a diff in the pull request:

    https://github.com/apache/commons-text/pull/57#discussion_r129102634
  
    --- Diff: src/main/java/org/apache/commons/text/WordUtils.java ---
    @@ -747,45 +750,29 @@ public static boolean containsAllWords(final CharSequence word, final CharSequen
             return true;
         }
     
    -    //-----------------------------------------------------------------------
    +    // -----------------------------------------------------------------------
         /**
    -     * Is the character a delimiter.
    +     * <p>
    +     * Converts an array of delimiters to a hash set of code points. Code point of space(32) is added as the default
    +     * value if delimiters is null. The generated hash set provides O(1) lookup time.
    +     * </p>
          *
    -     * @param ch  the character to check
    -     * @param delimiters  the delimiters
    -     * @return true if it is a delimiter
    +     * @param delimiters set of characters to determine capitalization, null means whitespace
    +     * @return Set<Integer>
          */
    -    public static boolean isDelimiter(final char ch, final char[] delimiters) {
    --- End diff --
    
    Rather removing we should keep this method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org