Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
From: TheRealHaui <git@git.apache.org>
To: dev@commons.apache.org
Reply-To: dev@commons.apache.org
References: <git-pr-27-commons-imaging@git.apache.org>
In-Reply-To: <git-pr-27-commons-imaging@git.apache.org>
Subject: [GitHub] commons-imaging pull request #27: Increase code coverage one
Content-Type: text/plain
Message-Id: <20170717172155.94177E382F@git1-us-west.apache.org>
Date: Mon, 17 Jul 2017 17:21:55 +0000 (UTC)
archived-at: Mon, 17 Jul 2017 17:21:57 -0000

Github user TheRealHaui commented on a diff in the pull request:

    https://github.com/apache/commons-imaging/pull/27#discussion_r127768831
  
    --- Diff: src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceTest.java ---
    @@ -66,6 +64,22 @@ protected File createTempFile(final byte src[]) throws IOException {
             }
             final byte longArray[] = (baos.toByteArray());
     
    -        return new byte[][] { emptyArray, single, simple, zeroes, longArray, };
    +        return new byte[][]{emptyArray, single, simple, zeroes, longArray,};
    +    }
    +
    +    @Test
    --- End diff --
    
    Yes, I know.
    However, for what reason ever I experienced a lot of people preferring the try/catch notation over the annotation approach.
    That's why I write/wrote it this way.
    In the hope to have to rewrite as less code in the end as possible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org