commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Amey Jadiye <ameyjad...@gmail.com>
Subject Re: PR Merge process lang vs text ?
Date Fri, 14 Jul 2017 20:44:42 GMT
well It's still confusing...

Example.

https://github.com/apache/commons-lang/pull/270

Here in #270 asfgit merged the PR

While

 https://github.com/apache/commons-lang/pull/274

Here in #274 asfgit closed PR.

Regards,
Amey


On Sat, Jul 15, 2017, 2:07 AM Gary Gregory <garydgregory@gmail.com> wrote:

> If a Git commit comment says "Closes #<PR#>" like "Closes #29", PR #29 will
> be closed. I forget to do that sometimes.
>
> Gary
>
> On Fri, Jul 14, 2017 at 1:29 PM, Amey Jadiye <ameyjadiye@gmail.com> wrote:
>
> > I wonder is there different process for accepting PR in text and lang ?
> >
> > Whenever I open PR for text ,after acceptance it says "asfgit merged
> > branch" and it automatically shows pr status as #merged on github while
> for
> > lang after merging my code PR stays open and I have to manually close it?
> >
> > Regards,
> > Amey
> >
> > ---------- Forwarded message ---------
> > From: garydgregory <git@git.apache.org>
> > Date: Sat, Jul 15, 2017, 12:21 AM
> > Subject: [GitHub] commons-lang issue #277: run maven defaultGoal from
> > Travis
> > To: <issues@commons.apache.org>
> >
> >
> > Github user garydgregory commented on the issue:
> >
> >     https://github.com/apache/commons-lang/pull/277
> >
> >     Patch applied. Thank you!
> >
> >
> > ---
> > If your project is set up for it, you can reply to this email and have
> your
> > reply appear on GitHub as well. If your project does not have this
> feature
> > enabled and wishes so, or if the feature is enabled but not working,
> please
> > contact infrastructure at infrastructure@apache.org or file a JIRA
> ticket
> > with INFRA.
> > ---
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message