commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [VOTE] Release Commons Email 1.5 Based on RC1
Date Sun, 30 Jul 2017 20:24:59 GMT
On 30 July 2017 at 16:30, Matt Sicker <boards@gmail.com> wrote:
> If the build is anything like Log4j's, it probably has a separate rat
> config for the release profile than it does by default.

If rat and Clirr are run as part of the the site build they use the
report settings whereas 'mvn clirr:check' will use the build settings.

The build and report section configs need to agree.

> On 30 July 2017 at 10:27, Gary Gregory <garydgregory@gmail.com> wrote:
>
>> I always run:
>>
>> mvn apache-rat:check
>>
>> And
>>
>> mvn clirr:check
>>
>> Gary
>>
>> On Jul 30, 2017 07:12, "Stefan Bodewig" <bodewig@apache.org> wrote:
>>
>> > On 2017-07-30, Gary Gregory wrote:
>> >
>> > > Branding: The RELEASE-NOTES.txt file should start with "Apache Commons
>> > > Email Package" instead of "Commons Email Package".
>> >
>> > I was under the impression it had been generated by the commons-build
>> > plugin. Anyway, will fix it when I publish the release (no reason to
>> > vote on that).
>> >
>> > > RAT check fails with:
>> >
>> > > Unapproved licenses:
>> >
>> > >   src/test/resources/eml/attachment-only.eml
>> > >   src/test/resources/eml/html-attachment-content-disposition.eml
>> > >   src/test/resources/eml/html-attachment-encoded-filename.eml
>> > >   src/test/resources/eml/html-attachment.eml
>> > >   src/test/resources/eml/multipart-report.eml
>> > >   src/test/resources/eml/multipart-text-attachment-only.eml
>> > >   src/test/resources/eml/multipart-text-attachment.eml
>> > >   src/test/resources/eml/outofmemory-no-header-seperation.eml
>> > >   src/test/resources/eml/simple-reply.eml
>> > >   src/test/resources/eml/simple.eml
>> >
>> > The pom contains
>> >
>> >             <plugin>
>> >                 <groupId>org.apache.rat</groupId>
>> >                 <artifactId>apache-rat-plugin</artifactId>
>> >                 <configuration>
>> >                     <excludes>
>> >                         <exclude>src/test/resources/eml/*.eml</exclude>
>> >                     </excludes>
>> >                 </configuration>
>> >             </plugin>
>> >
>> > and RAT is prefectly happy inside the site build. How do you execute the
>> > rat check? Comparing the POM with the one of Compress I see the plugin
>> > is configured inside the <reporting> section for Email only, while it
is
>> > inside <build> for Compress. This may explain the difference when
>> > running rat checks directly.
>> >
>> > Stefan
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> > For additional commands, e-mail: dev-help@commons.apache.org
>> >
>> >
>>
>
>
>
> --
> Matt Sicker <boards@gmail.com>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message