commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From PascalSchumacher <...@git.apache.org>
Subject [GitHub] commons-text pull request #56: add-some-Unit Tests
Date Thu, 20 Jul 2017 18:32:14 GMT
Github user PascalSchumacher commented on a diff in the pull request:

    https://github.com/apache/commons-text/pull/56#discussion_r128594766
  
    --- Diff: src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
    @@ -416,6 +416,81 @@ public void testSetFormatsByArgumentIndex() {
             emf.setFormatsByArgumentIndex(new Format[]{new LowerCaseFormat(), new UpperCaseFormat()});
         }
     
    +    @Test
    +    public void testFailsToCreateExtendedMessageFormatTakingThreeArgumentsThrowsIllegalArgumentExceptionOne()
{
    --- End diff --
    
    The name of this test method (and some of the ones below) seems misleading, because the
name suggests that the three argument constructor is tested, but the tests calls the two argument
constructor.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message