commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbduncan <...@git.apache.org>
Subject [GitHub] commons-imaging issue #29: Improve various unit tests style
Date Wed, 19 Jul 2017 20:23:05 GMT
Github user jbduncan commented on the issue:

    https://github.com/apache/commons-imaging/pull/29
  
    Looks much better, thanks @TheRealHaui!
    
    As I discussed in #28, I'm sure there's area for improvement on the whitespace/readability
front, but that would require running `mvn checkstyle:check` and fixing the warnings it reports
in a separate PR.
    
    On a related note, Travis seems to complaining that GreyScaleRountripTest (unrelated to
this PR AFAICT) killed the JVM process during testing. Perhaps Travis just needs to be restarted
and the test will run properly? But I don't immediately know how one would restart Travis...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message