commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbduncan <...@git.apache.org>
Subject [GitHub] commons-text pull request #56: add-some-Unit Tests
Date Tue, 18 Jul 2017 00:04:57 GMT
Github user jbduncan commented on a diff in the pull request:

    https://github.com/apache/commons-text/pull/56#discussion_r127854888
  
    --- Diff: src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
    @@ -338,10 +339,11 @@ private void checkBuiltInFormat(final String pattern, final Object[]
args, final
     
         /**
          * Test a built in format for the specified Locales, plus <code>null</code>
Locale.
    -     * @param pattern MessageFormat pattern
    +     *
    +     * @param pattern     MessageFormat pattern
          * @param fmtRegistry FormatFactory registry to use
    -     * @param args MessageFormat arguments
    -     * @param locales to test
    +     * @param args        MessageFormat arguments
    +     * @param locales     to test
    --- End diff --
    
    I think the lines were fine before, please consider reverting them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message