commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbduncan <...@git.apache.org>
Subject [GitHub] commons-text pull request #56: add-some-Unit Tests
Date Tue, 18 Jul 2017 00:04:57 GMT
Github user jbduncan commented on a diff in the pull request:

    https://github.com/apache/commons-text/pull/56#discussion_r127855540
  
    --- Diff: src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
    @@ -476,8 +578,8 @@ public Format getFormat(final String name, final String arguments,
final Locale
             public Format getFormat(final String name, final String arguments, final Locale
locale) {
                 return !"short".equals(arguments) ? null
                         : locale == null ? DateFormat
    -                            .getDateInstance(DateFormat.DEFAULT) : DateFormat
    -                            .getDateInstance(DateFormat.DEFAULT, locale);
    +                    .getDateInstance(DateFormat.DEFAULT) : DateFormat
    +                    .getDateInstance(DateFormat.DEFAULT, locale);
    --- End diff --
    
    I think these lines were reasonably indented before. Unless Checkstyle complains, please
consider reverting these lines.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message