commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbduncan <...@git.apache.org>
Subject [GitHub] commons-imaging pull request #28: Increase code coverage one
Date Mon, 17 Jul 2017 18:21:32 GMT
Github user jbduncan commented on a diff in the pull request:

    https://github.com/apache/commons-imaging/pull/28#discussion_r127782716
  
    --- Diff: src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceTest.java
---
    @@ -17,24 +17,22 @@
     
     package org.apache.commons.imaging.common.bytesource;
     
    -import static org.junit.Assert.assertTrue;
    +import org.apache.commons.imaging.ImagingTest;
    +import org.junit.Test;
     
    -import java.io.BufferedOutputStream;
    -import java.io.ByteArrayOutputStream;
    -import java.io.File;
    -import java.io.FileOutputStream;
    -import java.io.IOException;
    -import java.io.OutputStream;
    +import java.io.*;
     
    -import org.apache.commons.imaging.ImagingTest;
    +import static org.junit.Assert.assertEquals;
    +import static org.junit.Assert.assertTrue;
    +import static org.junit.Assert.fail;
     
     public abstract class ByteSourceTest extends ImagingTest {
         protected File createTempFile(final byte src[]) throws IOException {
             final File file = createTempFile("raw_", ".bin");
     
             // write test bytes to file.
             try (FileOutputStream fos = new FileOutputStream(file);
    -                OutputStream os = new BufferedOutputStream(fos)) {
    +             OutputStream os = new BufferedOutputStream(fos)) {
    --- End diff --
    
    No need to un-tab this line AFAICT.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message