commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbduncan <>
Subject [GitHub] commons-imaging pull request #28: Increase code coverage one
Date Mon, 17 Jul 2017 18:21:32 GMT
Github user jbduncan commented on a diff in the pull request:
    --- Diff: src/test/java/org/apache/commons/imaging/common/bytesource/
    @@ -17,24 +17,22 @@
     package org.apache.commons.imaging.common.bytesource;
    -import static org.junit.Assert.assertTrue;
    +import org.apache.commons.imaging.ImagingTest;
    +import org.junit.Test;
    -import org.apache.commons.imaging.ImagingTest;
    +import static org.junit.Assert.assertEquals;
    +import static org.junit.Assert.assertTrue;
    +import static;
    --- End diff --
    I'd keep the ordering and style of the imports as before; no need to rearrange them just
to import `assertEquals` and `fail`.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message