commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbduncan <...@git.apache.org>
Subject [GitHub] commons-imaging pull request #28: Increase code coverage one
Date Mon, 17 Jul 2017 18:21:32 GMT
Github user jbduncan commented on a diff in the pull request:

    https://github.com/apache/commons-imaging/pull/28#discussion_r127781035
  
    --- Diff: src/test/java/org/apache/commons/imaging/ImageDumpTest.java ---
    @@ -0,0 +1,44 @@
    +package org.apache.commons.imaging;
    +
    +import org.junit.Test;
    +
    +import java.awt.color.ColorSpace;
    +import java.awt.image.BufferedImage;
    +
    +import static org.junit.Assert.assertEquals;
    +
    +/**
    + * Unit tests for class {@link ImageDump}.
    + *
    + * @date 2017-07-13
    + * @see ImageDump
    + *
    + **/
    +public class ImageDumpTest{
    +
    +
    +    @Test
    +    public void testDumpColorSpace() {
    +
    +        ImageDump imageDump = new ImageDump();
    +        ColorSpace colorSpace = ColorSpace.getInstance(1004);
    +        imageDump.dumpColorSpace("Ku&]N>!4'C#Jzn+", colorSpace);
    +
    +        assertEquals(3, colorSpace.getNumComponents());
    +
    +    }
    --- End diff --
    
    Most test methods I've seen in commons-imaging prefer to have no blank lines at the start
and end of the test method body. I suggest removing the blank lines at the start and end of
`testDumpColorSpace`'s body here for consistency, so like this:
    
    ```java
    @Test 
    public void testDumpColorSpace() {
    ImageDump imageDump = new ImageDump();
            ColorSpace colorSpace = ColorSpace.getInstance(1004);
            imageDump.dumpColorSpace("Ku&]N>!4'C#Jzn+", colorSpace);
    
            assertEquals(3, colorSpace.getNumComponents());
    }


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message