commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From schaumb <...@git.apache.org>
Subject [GitHub] commons-cli pull request #12: [CLI-274] implement EXISTING_FILE_VALUE type h...
Date Fri, 09 Jun 2017 09:22:20 GMT
GitHub user schaumb opened a pull request:

    https://github.com/apache/commons-cli/pull/12

    [CLI-274] implement EXISTING_FILE_VALUE type handler

    when the user pass option type FileInputStream.class, I think the expected behavior for
the return value is the same type, which the user passed.
    Before this there was no check whether the file exist.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/schaumb/commons-cli patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-cli/pull/12.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #12
    
----
commit abfcc8211f529ab75f3b3edd4a827e484109eb0b
Author: Bela Schaum <schaumb@users.noreply.github.com>
Date:   2017-04-17T11:45:09Z

    implement EXISTING_FILE_VALUE type handler
    
    when the user pass option type FileInputStream.class, I think the expected behavior for
the return value is the same type, which the user passed.
    Before this there was no check whether the file exist.

commit a315e187908d184b1d40f9e7425bc65333a2d07a
Author: Bela Schaum <schaumb@users.noreply.github.com>
Date:   2017-04-17T14:03:11Z

    [CLI-274] misseed import

commit 9039cbd454346276c632ae2424a3c20e18a2d276
Author: Bela Schaum <schaumb@users.noreply.github.com>
Date:   2017-04-17T14:21:42Z

    Update PatternOptionBuilderTest.java

commit c1cbe9dd69f80b627ea046095af842bfafb15803
Author: Bela Schaum <schaumb@users.noreply.github.com>
Date:   2017-04-17T14:27:45Z

    Update PatternOptionBuilderTest.java

commit e3d65b0ee3b08599bd787a7721afc326d1bcccf1
Author: Bela Schaum <schaumb@users.noreply.github.com>
Date:   2017-04-17T14:33:42Z

    Update PatternOptionBuilderTest.java
    
    -.-' sry

commit fac33304c67496380cd168d71cac79dbc0e60142
Author: Bela Schaum <schaumb@users.noreply.github.com>
Date:   2017-04-17T14:39:15Z

    Update PatternOptionBuilderTest.java
    
    really exist file name?

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message