commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benedikt Ritter <brit...@apache.org>
Subject Re: [LANG] Add Automatic-Module-Name MANIFEST entry
Date Thu, 08 Jun 2017 06:16:35 GMT
Hi,

> Am 07.06.2017 um 15:09 schrieb Jörg Schaible <joerg.schaible@bpm-inspire.com>:
> 
> Stefan Bodewig wrote:
> 
>> On 2017-06-07, Benedikt Ritter wrote:
>> 
>>> here [1] is my proposal on how to add the Automatic-Module-Name entry
>>> to MANIFEST. This just duplicates the maven-jar-plugin configuration
>>> from parent pom. I don’t want to wait much longer to release
>>> 3.6. After we have implemented a more general solution in parent pom,
>>> we can revert this fix.
>> 
>> I've done something similar to Compress already. As Compress has been
>> overriding the jar-plugin configuration already (in order to add a
>> main-class) there's been no other option anyway.
>> 
>> I'm afraid Compress is not the only component that overrides the
>> parent's jar config and thus will require copying the change manually
>> even if you happen to find a solution for parent.
> 
> You don't have to overwrite the jar's parent config. Simply append/overwrite 
> the existing entries:
> 
>  <configuration>
>    <archive combine.children="append">
>      <manifestEntries>
>        <Main-Class>org.apache.commons.compress.archivers.Lister</Main-
> Class>
>      </manifestEntries>
>    </archive>
>  </configuration>
> 
> That's it ;-)

Awesome, I could use this trick to add the Automatic-Module-Name entry without having to duplicate
the whole maven-jar-plugin configuration!

Thank you
Benedikt

> 
> Cheers,
> Jörg
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message