commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rob Tompkins <chtom...@gmail.com>
Subject Re: [VOTE] Release Commons Fileupload 1.3.3 based on RC5
Date Wed, 07 Jun 2017 12:09:15 GMT

> On Jun 7, 2017, at 3:19 AM, Bruno P. Kinoshita <brunodepaulak@yahoo.com.br.INVALID>
wrote:
> 
> [ X ] +1 Release it.
> 
> All tests pass, artifacts generated successfully, and site correctly generated too with
`mvn clean test install -e -X` on the following environments.
> 
> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-11T05:41:47+13:00)
> Maven home: /opt/maven
> Java version: 1.8.0_131, vendor: Oracle Corporation
> Java home: /usr/lib/jvm/java-8-oracle/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.4.0-78-generic", arch: "amd64", family: "unix"
> 
> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-11T05:41:47+13:00)
> Maven home: /opt/maven
> Java version: 1.7.0_80, vendor: Oracle Corporation
> Java home: /usr/lib/jvm/java-7-oracle/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.4.0-78-generic", arch: "amd64", family: "unix"
> 
> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-11T05:41:47+13:00)
> Maven home: /opt/maven
> Java version: 1.8.0, vendor: IBM Corporation
> Java home: /home/kinow/Development/java/ibm-java-x86_64-80/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.4.0-78-generic", arch: "amd64", family: "unix"
> 
> 
> Reports look OK. Noticed that coverage could be enhanced for future releases. There are
some classes with 0 tests (PortletFileUpload and PortletRequestContext) so I'm adding a note
in my todo list to write some tests when I have some spare time (happy if anyone does so first
:).
> 
> I think NOTICE.txt was not updated to include 2017 in the year (I believe we manually
update this file?), but that's trivial and definitely not a blocker (I guess we just fix it
later - if necessary).
> 
> My local web site has changes report showing 1.3.3 with date as tbd. Yours is showing
1.4 with date set to today, but I guess it's temporary and after the release it will display
1.3.3 and another date? Anyway, FILEUPLOAD-279 is not there, but this shouldn't be a blocker.

I actually uploaded the site from the master branch because there were considerable differences
between the RC and the master branch. I figured we would use the site from the master branch.
I’ve just changed that for the sake of release validation.

-Rob

> 
> Didn't have much time so checked only the main jar gpg signature, and it's also looking
OK.
> 
> Go for it, and thanks for preparing the release!
> Cheers
> 
> Bruno
> 
> ps: first time I look at the DOAP file while reviewing a release... there are some releases
missing there, but I guess it's not updated automagically by Maven... maybe those blocks could
be removed?
> ________________________________
> From: Rob Tompkins <chtompki@apache.org>
> To: Commons Developers List <dev@commons.apache.org> 
> Sent: Wednesday, 7 June 2017 6:26 AM
> Subject: [VOTE] Release Commons Fileupload 1.3.3 based on RC5
> 
> 
> 
> Hello all,
> 
> 
> This is a [VOTE] for releasing Apache Commons Fileupload 1.3.3 (from RC5).
> 
> 
> Tag name:
> 
>   commons-fileupload-1.3.3-RC5 (signature can be checked from git using 'git tag -v')
> 
> 
> Tag URL:
> 
>  https://git-wip-us.apache.org/repos/asf?p=commons-fileupload.git;a=commit;h=dd2238b1671644cfead0e87c24a8ac61b4039084
> 
> 
> Commit ID the tag points at:
> 
>   dd2238b1671644cfead0e87c24a8ac61b4039084
> 
> 
> Site:
> 
>  http://home.apache.org/~chtompki/commons-fileupload-1.3.3-RC5
> 
> 
> Distribution files (committed at revision 19901):
> 
>  https://dist.apache.org/repos/dist/dev/commons/fileupload/
> 
> 
> Distribution files hashes (SHA1):
> 
>   commons-fileupload-1.3.3-bin.tar.gz
> 
>   (SHA1: 2f4a9672168641ff726974a3b7cc68b97d1212fa)
> 
>   commons-fileupload-1.3.3-bin.zip
> 
>   (SHA1: b66e2c434ddbda90dfc9e92af4775d9777524bfa)
> 
>   commons-fileupload-1.3.3-src.tar.gz
> 
>   (SHA1: 71294a7d737a8ced04934c222ae6dfb16e4d8d73)
> 
>   commons-fileupload-1.3.3-src.zip
> 
>   (SHA1: 661172a2f62b460c4b754b7a0f04d412afabde52)
> 
> 
> These are the Maven artifacts and their hashes:
> 
>   commons-fileupload-1.3.3-javadoc.jar
> 
>   (SHA1: 92d2fc371379d64a822150ca3882157564dd3f99)
> 
>   commons-fileupload-1.3.3-sources.jar
> 
>   (SHA1: c8c7bcb851fb5af0b19e4ea845cf2fc03de6f673)
> 
>   commons-fileupload-1.3.3-test-sources.jar
> 
>   (SHA1: 5e0d8c621d38694e0f2960ab2899ee1d67f2b708)
> 
>   commons-fileupload-1.3.3-tests.jar
> 
>   (SHA1: 20510147958fc759582e6ede789ccf31d056b232)
> 
>   commons-fileupload-1.3.3.jar
> 
>   (SHA1: fd754c7518772453aea1d5ffc32cb5ce0ebc0e40)
> 
>   commons-fileupload-1.3.3.pom
> 
>   (SHA1: 97d781eafc190f4fee3abf11f9ec8076f5f7b58c)
> 
> 
> KEYS file to check signatures:
> 
>  http://www.apache.org/dist/commons/KEYS
> 
> 
> Maven artifacts:
> 
>  https://repository.apache.org/content/repositories/orgapachecommons-1249
> 
> 
> Please select one of the following options[1]:
> 
>  [ ] +1 Release it.
> 
>  [ ] +0 Go ahead; I don't care.
> 
>  [ ] -0 There are a few minor glitches: ...
> 
>  [ ] -1 No, do not release it because ...
> 
> 
> This vote will be open at least 72 hours, i.e. until 
> 
> 2017-06-09T19:00:00Z
> 
> (this is UTC time).
> 
> --------
> 
> 
> Cheers,
> 
> -Rob
> 
> 
> [1] http://apache.org/foundation/voting.html
> 
> ---------------------------------------------------------------------
> 
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> 
> For additional commands, e-mail: dev-help@commons.apache.org
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message