commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kinow <...@git.apache.org>
Subject [GitHub] commons-text pull request #54: TEXT-93: RandomStringGenerator accepts a list...
Date Sat, 24 Jun 2017 10:09:51 GMT
Github user kinow commented on a diff in the pull request:

    https://github.com/apache/commons-text/pull/54#discussion_r123874569
  
    --- Diff: src/main/java/org/apache/commons/text/RandomStringGenerator.java ---
    @@ -76,23 +78,29 @@
         private final TextRandomProvider random;
     
         /**
    +     * The source of provided charachters.
    +     */
    +    private final List<Character> characterList;
    +
    +    /**
          * Constructs the generator.
    -     *
    -     * @param minimumCodePoint
    +     *  @param minimumCodePoint
          *            smallest allowed code point (inclusive)
          * @param maximumCodePoint
          *            largest allowed code point (inclusive)
          * @param inclusivePredicates
    -     *            filters for code points
    -     * @param random
    -     *            source of randomness
    + *            filters for code points
    --- End diff --
    
    Indentation got a bit messed up here, and the param entry for minimumCodePoint too


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message