commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jvz <...@git.apache.org>
Subject [GitHub] commons-text pull request #50: TEXT-90: Add CharacterPredicates for ASCII le...
Date Thu, 15 Jun 2017 01:47:20 GMT
Github user jvz commented on a diff in the pull request:

    https://github.com/apache/commons-text/pull/50#discussion_r122104232
  
    --- Diff: src/test/java/org/apache/commons/text/CharacterPredicatesTest.java ---
    @@ -44,4 +44,77 @@ public void testDigits() {
             assertFalse(CharacterPredicates.DIGITS.test('.'));
             assertFalse(CharacterPredicates.DIGITS.test('L'));
         }
    +
    +    @Test
    +    public void testArabicNumerals() {
    --- End diff --
    
    This whole test looks repetitive enough to benefit from [parameterized tests](https://github.com/junit-team/junit4/wiki/Parameterized-tests)
or even possibly [theories](https://github.com/junit-team/junit4/wiki/Theories).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message