commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From britter <...@git.apache.org>
Subject [GitHub] commons-cli pull request #12: [CLI-274] implement EXISTING_FILE_VALUE type h...
Date Tue, 13 Jun 2017 06:12:39 GMT
Github user britter commented on a diff in the pull request:

    https://github.com/apache/commons-cli/pull/12#discussion_r121589195
  
    --- Diff: src/test/java/org/apache/commons/cli/PatternOptionBuilderTest.java ---
    @@ -159,13 +161,15 @@ public void testURLPattern() throws Exception
         @Test
         public void testExistingFilePattern() throws Exception
         {
    -        final Options options = PatternOptionBuilder.parsePattern("f<");
    +        final Options options = PatternOptionBuilder.parsePattern("f<g<");
    --- End diff --
    
    Looking at this, I think we're doing to many things at once in this test. Why don't we
split this test up into to separate tests? One for `f<` and one for `g<`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message