commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chtompki <...@git.apache.org>
Subject [GitHub] commons-text pull request #45: Added IBM Jdk8 build support to travis-ci con...
Date Mon, 12 Jun 2017 11:52:29 GMT
Github user chtompki commented on a diff in the pull request:

    https://github.com/apache/commons-text/pull/45#discussion_r121372102
  
    --- Diff: .travis.yml ---
    @@ -21,8 +21,15 @@ jdk:
       - oraclejdk7
       - oraclejdk8
     
    +services:
    +  - docker
    +
    +before_install:
    +  - docker pull ibmcom/ibmjava:8-sdk
    +
     script:
    -  - mvn test apache-rat:check clirr:check checkstyle:check findbugs:check javadoc:javadoc
    +  - mvn
    +  - docker run -v `pwd`:/work library/ibmjava:8-sdk /bin/bash -c "apt-get update &&
cd work && apt-get install -y maven && mvn"
    --- End diff --
    
    I'm about to pull this in, but I wonder if we could put in either issues or PR's on the
official "maven" docker image whose docker files are given here: https://github.com/carlossg/docker-maven
such that we could get oracle java as well as ibm java supported.
    
    I've opened the following issue for tracking purposes:
    https://github.com/carlossg/docker-maven/issues/25
    
    I'm not sure, but I could see licensing being the main blocker to those being brought
into the project. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message