Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
From: Benedikt Ritter <britter@apache.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PARENT][PROPOSAL] Add Automatic-Module-Name MANIFEST entry
Date: Sun, 21 May 2017 10:50:13 -0400
References: <6405DF56-2169-40A6-A28B-DAE419CE7E41@apache.org>
 <CACZkXPyj5xCbhwg80n5837Ze9rGzvke62EEmf21tqbkKMrYToQ@mail.gmail.com>
 <CACzrW9B+HHMJQzn+Ec-C8M47h5N7uhZN-g9aXS_Sp-No9Uc_tA@mail.gmail.com>
To: Commons Developers List <dev@commons.apache.org>
In-Reply-To: <CACzrW9B+HHMJQzn+Ec-C8M47h5N7uhZN-g9aXS_Sp-No9Uc_tA@mail.gmail.com>
Message-Id: <EBEBBDA6-9B05-4A34-900B-751150F2151C@apache.org>
archived-at: Sun, 21 May 2017 14:50:54 -0000

Hello Stephen,

> Am 19.05.2017 um 04:52 schrieb Stephen Colebourne =
<scolebourne@joda.org>:
>=20
> Is reusing ${commons.osgi.symbolicName} a good idea?

I thought it is, because this way we will automatically have the =
additional entry after we update a component to the new parent pom =
version. :o)

> It seems to me that each project should have to opt-in to this
> attribute, so I'd add a new ${commons.automatic.moduile.name}
> variable.

I=E2=80=99d go with ${commons.automatic-module-name}.

>=20
> One reason is that the attribute should only be added if the project
> is suitable for use as a module (eg. no packages that clash with any
> other module, doesn't force cycles in dependencies). I'm not convinced
> that all commons projects are valid yet.

Okay, how do we find out whether a component is valid?

>=20
> The second reason is that we will ultimately need to add a real
> module-info.java file to each module. The Automatic-Module-Name
> attribute is temporary while the commons projects are worked through
> and released. When there is a module-info.java file, we definitely
> don't want the Automatic-Module-Name attribute (although it does no
> harm, it would look bad).
>=20
> The opt-in approach is slightly more work, but better in the long run =
I think.

I=E2=80=99ll try to come up with something when I have the time again.

Thank you!
Benedikt

>=20
> WDYT?
> Stephen
>=20
>=20
> On 18 May 2017 at 20:21, Gary Gregory <garydgregory@gmail.com> wrote:
>> On May 18, 2017 12:09 PM, "Benedikt Ritter" <britter@apache.org> =
wrote:
>>=20
>> Hi,
>>=20
>> here is my proposal on how to get the Automatic-Module-Name entry =
into our
>> MANIFEST files. This change has to be made only in commons parent. =
This is
>> the change:
>>=20
>> Index: pom.xml
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> --- pom.xml     (revision 1795551)
>> +++ pom.xml     (working copy)
>> @@ -601,6 +601,7 @@
>>               <Implementation-Build>${implementation.build}</
>> Implementation-Build>
>>               =
<X-Compile-Source-JDK>${maven.compiler.source}</X-Compile-
>> Source-JDK>
>>               =
<X-Compile-Target-JDK>${maven.compiler.target}</X-Compile-
>> Target-JDK>
>> +              <Automatic-Module-Name>${commons.osgi.symbolicName}</
>> Automatic-Module-Name>
>>             </manifestEntries>
>>           </archive>
>>         </configuration>
>>=20
>>=20
>> For Commons Lang this will create:
>>=20
>>   Automatic-Module-Name: org.apache.commons.lang3
>>=20
>>=20
>> WDYT?
>>=20
>>=20
>> Seems reasonable enough.
>>=20
>> Gary
>>=20
>> Benedikt
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>=20
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>=20


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org