Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
MIME-Version: 1.0
In-Reply-To: <CAM+TppKO7Vn6K9gr-xk4HPaLka=tNQWesf=jJDVZka01nR7Z7A@mail.gmail.com>
References: <CACZkXPzzUW5SCrF6GmdFNknuSv27DdTCHjSU3_i-scnc2Aw7qA@mail.gmail.com>
 <CAM+Tpp+_j3bRF8XkMD6_beJS7E5fDF_O2M+48G1OoGpgKXV_yQ@mail.gmail.com> <CAM+TppKO7Vn6K9gr-xk4HPaLka=tNQWesf=jJDVZka01nR7Z7A@mail.gmail.com>
From: "Javen O'Neal" <onealj@apache.org>
Date: Wed, 10 May 2017 20:10:03 -0700
Message-ID: <CAM+TppLe1Pp2ErOp6gS-DDyBasZj9mqLCm4Vbv8w+jopfrbK4Q@mail.gmail.com>
Subject: Re: Pair of nulls
To: Commons Developers List <dev@commons.apache.org>
Content-Type: multipart/alternative; boundary=f403043c3a88e31b3c054f36ecca
archived-at: Thu, 11 May 2017 03:10:07 -0000

--f403043c3a88e31b3c054f36ecca
Content-Type: text/plain; charset=UTF-8

+1

The of method should check if all elements are null, and if so to return
the NULL singleton. This would reduce the number of objects created and
garbage collected.

So long as ImmutablePair and ImmutableTriple classes are final (not
subclassable), then identity checking could be used in place of equality
checking when comparing against a null tuple. This would be marginally
faster.

Any preference of being explicit (redundant) here?
ImmutablePair.NULL_PAIR and ImmutableTriple.NULL_TRIPLE

On May 10, 2017 7:35 PM, "Gary Gregory" <garydgregory@gmail.com> wrote:

Hi All,

Any thoughts for or against adding the following to ImmutablePair:


    /**
     * An immutable pair of nulls.
     */
    // This is not defined with generics to avoid warnings in call sites.
    @SuppressWarnings("rawtypes")
    public static final ImmutablePair NULL = ImmutablePair.of(null, null);

Same for ImmutableTriple.

?

Thank you,
Gary

--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<https://www.amazon.com/gp/product/1617290459/ref=as_li_
tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&
linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>

<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=
1617290459>
JUnit in Action, Second Edition
<https://www.amazon.com/gp/product/1935182021/ref=as_li_
tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&
linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22>

<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=
1935182021>
Spring Batch in Action
<https://www.amazon.com/gp/product/1935182951/ref=as_li_
tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&
linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%
7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=
1935182951>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

--f403043c3a88e31b3c054f36ecca--