commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [PARENT][PROPOSAL] Add Automatic-Module-Name MANIFEST entry
Date Mon, 22 May 2017 13:19:05 GMT
On 22 May 2017 at 13:14, Rob Tompkins <chtompki@gmail.com> wrote:
>
>> On May 22, 2017, at 8:10 AM, Stephen Colebourne <scolebourne@joda.org> wrote:
>>
>> On 22 May 2017 at 12:51, Rob Tompkins <chtompki@gmail.com> wrote:
>>> You could, in the parent, declare in the properties section beside the declaration
of “commons.osgi.symbolicName”, another property pointing to that as
>>>
>>> <commons.automatic-module-name>${commons.osgi.symbolicName}</commons.automatic-module-name>
>>>
>>> and then allow people to override that in their local poms. That way you wouldn’t
get the blank lines.
>>
>> True, but I want to ensure that we only add it to components where it
>> is valid (and we have manually checked it is valid). Which I think
>> requires us to do it in each subproject.
>
> We might be able to contrive something using antrun after compile that predicates on
the property being populated, but that feels extra hacky.

It's possible to have a profile depend on the presence of a file.

So just create an empty file when the property is available for use.

>> Stephen
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message