commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: [all] Should our gitignore files contain only build-related entries?
Date Sat, 27 May 2017 15:25:48 GMT
On May 27, 2017 7:23 AM, "Bernd Eckenfels" <ecki@zusammenkunft.net> wrote:

I vote for a default set optimized for build-related file but allow all
commiters to include relevant files (Specifically Editor and IDE specific).
One could set up this locally, but it is a better experience for new
developers if they use common tools and don't hit a dirty repo. After all a
few more lines in .gitignore do not hurt...


Sounds reasonable to me.

Gary


Gruss
Bernd
--
http://bernd.eckenfels.net
________________________________
From: Bruno P. Kinoshita <brunodepaulak@yahoo.com.br.INVALID>
Sent: Saturday, May 27, 2017 3:29:22 PM
To: Commons Developers List
Subject: [all] Should our gitignore files contain only build-related
entries?

Hi,

[collections] recently received a pull request [1] to add VIM files to the
gitignore file. Its currently gitignore contains only a few entries for
Eclipse ([lang] has more entries for Eclipse).

I remember asking something similar, and learning about the global
gitignore. But besides that, in the same thread, Benedikt suggested having
only build files ignored in our gitignore files [2], which I think is a
good idea. Our components do not follow any rule for gitignore files I
think. I normally check [lang] when I need to add a .gitignore to a new
computer, but just realized [text] and [lang] gitignore files differ
([lang] has a .checkstyle file under the Eclipse ignored files).


I'm okay merging the pull request for [collections], but then we may also
add the remaining entries from [lang] there... except this pull request
adds *.swp which is missing from [lang]. So should we add it there too?

Some days ago I used NetBeans to test a generics suppress warning message
[3], but we may have developers using it as main IDE too. Would it be all
right to merge pull requests for it too? Or for files generated by plug-ins
for Eclipse/IntelliJ/etc?
What about 1) leaving only files generated by our build tools, 2) add a
comment to the .gitignore file describing how it works with links, 3) add a
comment to
https://wiki.apache.org/commons/UsingGIT and/or to the CONTRIBUTING.md
perhaps with a sample global gitignore file?

Cheers
Bruno

[1] https://github.com/apache/commons-collections/pull/21
[2] http://markmail.org/message/yvflc6kxgjalhldx?q=global+
gitignore+list:org%2Eapache%2Ecommons%2Edev#query:global%
20gitignore%20list%3Aorg.apache.commons.dev+page:1+mid:
ioex63sxnf6culwb+state:results
[3] https://github.com/apache/commons-collections/pull/17

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message