commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bodewig <...@git.apache.org>
Subject [GitHub] commons-compress issue #24: COMPRESS-391: Allow alignment on zip content
Date Fri, 05 May 2017 09:37:42 GMT
Github user bodewig commented on the issue:

    https://github.com/apache/commons-compress/pull/24
  
    Many thanks @kvr000 
    
    Have you thought about adding a class implementing `ZipExtraField` for padding? You could
add that to the entry if you detect padding is necessary and could remove code that now needs
to know about the encoding of extra fields from `ZipArchiveOutputStream`. The central directory
size should be 0 then.
    
    It would also preserve the padding information when an archive is read which may be useful
when re-packing existing entries as you could strip or modify the padding extra field directly.
    
    Finally I wonder whether `setAlignment` should reject values bigger than 64k right away.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message